fix hip-build.sh about compiler-rt #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build compiler-rt as runtime instead of project. This will use freshly built clang to build compiler-rt instead of the system compiler. Also use lld to link compiler-rt. Both can lower the risk of encounter issues with old system compiler and linker. Fixes buildbot failure https://lab.llvm.org/buildbot/#/builders/123/builds/1580
Contributor
Author
|
Since it is urgent. I will merge it first. |
rampitec
reviewed
Jul 11, 2024
rampitec
left a comment
rampitec
left a comment
There was a problem hiding this comment.
LGTM, thanks! And I didn't know this was an option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build compiler-rt as runtime instead of project. This will use freshly built clang to build compiler-rt instead of the system compiler. Also use lld to link compiler-rt. Both can lower the risk of encounter issues with old system compiler and linker.
Fixes buildbot failure https://lab.llvm.org/buildbot/#/builders/123/builds/1580