Expose the missing flag bit FlagAllCallsDescribed#188477
Closed
dingxiangfei2009 wants to merge 1 commit intollvm:mainfrom
Closed
Expose the missing flag bit FlagAllCallsDescribed#188477dingxiangfei2009 wants to merge 1 commit intollvm:mainfrom
dingxiangfei2009 wants to merge 1 commit intollvm:mainfrom
Conversation
Signed-off-by: Xiangfei Ding <[email protected]>
Member
|
@llvm/pr-subscribers-debuginfo Author: wieDasDing (dingxiangfei2009) ChangesIt appears that two headers did not sync up. Now the flag bit should also be available on the C side. 1 Files Affected:
diff --git a/llvm/include/llvm-c/DebugInfo.h b/llvm/include/llvm-c/DebugInfo.h
index 70da3a61a46d8..7d0b80de2cd60 100644
--- a/llvm/include/llvm-c/DebugInfo.h
+++ b/llvm/include/llvm-c/DebugInfo.h
@@ -65,9 +65,10 @@ typedef enum {
LLVMDIFlagNonTrivial = 1 << 26,
LLVMDIFlagBigEndian = 1 << 27,
LLVMDIFlagLittleEndian = 1 << 28,
+ LLVMDIFlagAllCallsDescribed = 1 << 29,
LLVMDIFlagIndirectVirtualBase = (1 << 2) | (1 << 5),
- LLVMDIFlagAccessibility = LLVMDIFlagPrivate | LLVMDIFlagProtected |
- LLVMDIFlagPublic,
+ LLVMDIFlagAccessibility =
+ LLVMDIFlagPrivate | LLVMDIFlagProtected | LLVMDIFlagPublic,
LLVMDIFlagPtrToMemberRep = LLVMDIFlagSingleInheritance |
LLVMDIFlagMultipleInheritance |
LLVMDIFlagVirtualInheritance
@@ -151,9 +152,9 @@ typedef enum {
* The amount of debug information to emit.
*/
typedef enum {
- LLVMDWARFEmissionNone = 0,
- LLVMDWARFEmissionFull,
- LLVMDWARFEmissionLineTablesOnly
+ LLVMDWARFEmissionNone = 0,
+ LLVMDWARFEmissionFull,
+ LLVMDWARFEmissionLineTablesOnly
} LLVMDWARFEmissionKind;
/**
@@ -1252,7 +1253,8 @@ LLVM_C_ABI LLVMMetadataRef
LLVMDIGlobalVariableExpressionGetVariable(LLVMMetadataRef GVE);
/**
- * Retrieves the \c DIExpression associated with this global variable expression.
+ * Retrieves the \c DIExpression associated with this global variable
+ * expression.
* \param GVE The global variable expression.
*
* @see llvm::DIGlobalVariableExpression::getExpression()
|
phyBrackets
reviewed
Mar 25, 2026
Member
phyBrackets
left a comment
phyBrackets
left a comment
There was a problem hiding this comment.
Please remove the unrelated formatting.
Contributor
Author
|
I will delegate to the PR #187907 that I wasn't aware of when authoring this PR. There the diff is cleaner. Thank you for taking a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that two headers did not sync up. Now the flag bit should also be available on the C side.