[libc] Wrong guards for totalorderbf16 and totalordermagbf16#188241
Merged
[libc] Wrong guards for totalorderbf16 and totalordermagbf16#188241
totalorderbf16 and totalordermagbf16#188241Conversation
Member
|
@llvm/pr-subscribers-libc Author: Zorojuro (Sukumarsawant) ChangesCurrently the guards for and This Pr intends to fix that with correct guards as 2 Files Affected:
diff --git a/libc/src/math/totalorderbf16.h b/libc/src/math/totalorderbf16.h
index 2414852db92b8..31daec4ac64fb 100644
--- a/libc/src/math/totalorderbf16.h
+++ b/libc/src/math/totalorderbf16.h
@@ -6,8 +6,8 @@
//
//===----------------------------------------------------------------------===//
-#ifndef LLVM_LIBC_SRC_MATH_TOTALORDERF16_H
-#define LLVM_LIBC_SRC_MATH_TOTALORDERF16_H
+#ifndef LLVM_LIBC_SRC_MATH_TOTALORDERBF16_H
+#define LLVM_LIBC_SRC_MATH_TOTALORDERBF16_H
#include "src/__support/macros/config.h"
#include "src/__support/macros/properties/types.h"
@@ -18,4 +18,4 @@ int totalorderbf16(const bfloat16 *x, const bfloat16 *y);
} // namespace LIBC_NAMESPACE_DECL
-#endif // LLVM_LIBC_SRC_MATH_TOTALORDERF16_H
+#endif // LLVM_LIBC_SRC_MATH_TOTALORDERBF16_H
diff --git a/libc/src/math/totalordermagbf16.h b/libc/src/math/totalordermagbf16.h
index c48de1ca8e540..e60d28bf1d450 100644
--- a/libc/src/math/totalordermagbf16.h
+++ b/libc/src/math/totalordermagbf16.h
@@ -6,8 +6,8 @@
//
//===----------------------------------------------------------------------===//
-#ifndef LLVM_LIBC_SRC_MATH_TOTALORDERMAGF16_H
-#define LLVM_LIBC_SRC_MATH_TOTALORDERMAGF16_H
+#ifndef LLVM_LIBC_SRC_MATH_TOTALORDERMAGBF16_H
+#define LLVM_LIBC_SRC_MATH_TOTALORDERMAGBF16_H
#include "src/__support/macros/config.h"
#include "src/__support/macros/properties/types.h"
@@ -18,4 +18,4 @@ int totalordermagbf16(const bfloat16 *x, const bfloat16 *y);
} // namespace LIBC_NAMESPACE_DECL
-#endif // LLVM_LIBC_SRC_MATH_TOTALORDERMAGF16_H
+#endif // LLVM_LIBC_SRC_MATH_TOTALORDERMAGBF16_H
|
Sukumarsawant
changed the title
totalorderbf16 and totalordermagbf16totalorderbf16 and totalordermagbf16
lntue
approved these changes
Mar 25, 2026
lntue
changed the title
totalorderbf16 and totalordermagbf16totalorderbf16 and totalordermagbf16
ZXShady
pushed a commit
to ZXShady/llvm-project
that referenced
this pull request
Mar 26, 2026
…m#188241) Currently the guards for `totalorderbf16` and `totalordermagbf16` are as follows: ``` #ifndef LLVM_LIBC_SRC_MATH_TOTALORDERMAGF16_H #define LLVM_LIBC_SRC_MATH_TOTALORDERMAGF16_H - #endif // LLVM_LIBC_SRC_MATH_TOTALORDERMAGF16_H ``` and ``` #ifndef LLVM_LIBC_SRC_MATH_TOTALORDERF16_H #define LLVM_LIBC_SRC_MATH_TOTALORDERF16_H - #endif // LLVM_LIBC_SRC_MATH_TOTALORDERF16_H ``` As we can see these are for F16 and not BF16 . This Pr intends to fix that with correct guards as `TOTALORDERBF16` and `TOTALORDERMAGBF16`
ambergorzynski
pushed a commit
to ambergorzynski/llvm-project
that referenced
this pull request
Mar 27, 2026
…m#188241) Currently the guards for `totalorderbf16` and `totalordermagbf16` are as follows: ``` #ifndef LLVM_LIBC_SRC_MATH_TOTALORDERMAGF16_H #define LLVM_LIBC_SRC_MATH_TOTALORDERMAGF16_H - #endif // LLVM_LIBC_SRC_MATH_TOTALORDERMAGF16_H ``` and ``` #ifndef LLVM_LIBC_SRC_MATH_TOTALORDERF16_H #define LLVM_LIBC_SRC_MATH_TOTALORDERF16_H - #endif // LLVM_LIBC_SRC_MATH_TOTALORDERF16_H ``` As we can see these are for F16 and not BF16 . This Pr intends to fix that with correct guards as `TOTALORDERBF16` and `TOTALORDERMAGBF16`
Aadarsh-Keshri
pushed a commit
to Aadarsh-Keshri/llvm-project
that referenced
this pull request
Mar 28, 2026
…m#188241) Currently the guards for `totalorderbf16` and `totalordermagbf16` are as follows: ``` #ifndef LLVM_LIBC_SRC_MATH_TOTALORDERMAGF16_H #define LLVM_LIBC_SRC_MATH_TOTALORDERMAGF16_H - #endif // LLVM_LIBC_SRC_MATH_TOTALORDERMAGF16_H ``` and ``` #ifndef LLVM_LIBC_SRC_MATH_TOTALORDERF16_H #define LLVM_LIBC_SRC_MATH_TOTALORDERF16_H - #endif // LLVM_LIBC_SRC_MATH_TOTALORDERF16_H ``` As we can see these are for F16 and not BF16 . This Pr intends to fix that with correct guards as `TOTALORDERBF16` and `TOTALORDERMAGBF16`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the guards for
totalorderbf16andtotalordermagbf16are as follows:and
As we can see these are for F16 and not BF16 .
This Pr intends to fix that with correct guards as
TOTALORDERBF16andTOTALORDERMAGBF16