Skip to content

Revert "Reapply [Offload][lit] Link against SPIR-V DeviceRTL if present"#180743

Merged
sarnex merged 1 commit intomainfrom
revert-180231-litagainrtl
Feb 10, 2026
Merged

Revert "Reapply [Offload][lit] Link against SPIR-V DeviceRTL if present"#180743
sarnex merged 1 commit intomainfrom
revert-180231-litagainrtl

Conversation

@sarnex
Copy link
Copy Markdown
Member

@sarnex sarnex commented Feb 10, 2026

Reverts #180231

@sarnex sarnex merged commit 6c0ff8d into main Feb 10, 2026
6 of 11 checks passed
@sarnex sarnex deleted the revert-180231-litagainrtl branch February 10, 2026 14:22
@llvmbot
Copy link
Copy Markdown
Member

llvmbot commented Feb 10, 2026

@llvm/pr-subscribers-offload

Author: Nick Sarnie (sarnex)

Changes

Reverts llvm/llvm-project#180231


Full diff: https://github.com/llvm/llvm-project/pull/180743.diff

2 Files Affected:

  • (modified) offload/test/lit.cfg (+2-3)
  • (modified) offload/test/mapping/firstprivate_aligned.cpp (+1)
diff --git a/offload/test/lit.cfg b/offload/test/lit.cfg
index 898258f3e3cd0..0d5a9c95c1d95 100644
--- a/offload/test/lit.cfg
+++ b/offload/test/lit.cfg
@@ -166,8 +166,7 @@ elif config.operating_system == 'Darwin':
     config.test_flags += " -Wl,-rpath," + config.library_dir
     config.test_flags += " -Wl,-rpath," + config.omp_host_rtl_directory
 else: # Unices
-    if config.libomptarget_current_target != "nvptx64-nvidia-cuda" and \
-       not config.libomptarget_current_target.startswith('spirv'):
+    if config.libomptarget_current_target != "nvptx64-nvidia-cuda":
         config.test_flags += " -nogpulib"
     config.test_flags += " -Wl,-rpath," + config.library_dir
     config.test_flags += " -Wl,-rpath," + config.omp_host_rtl_directory
@@ -215,7 +214,7 @@ def add_libraries(source):
     if "gpu" not in config.available_features:
         return source
     if "intelgpu" in config.available_features:
-        # SPIR-V uses an out-of-tree linker and libc doesn't work.
+        # There is no DeviceRTL for Intel yet and libc doesn't work.
         return source
     if config.libomptarget_has_libc:
         return source + " -Xoffload-linker -lc " + \
diff --git a/offload/test/mapping/firstprivate_aligned.cpp b/offload/test/mapping/firstprivate_aligned.cpp
index ae6be0f0c07f4..bf09eb0b0f589 100644
--- a/offload/test/mapping/firstprivate_aligned.cpp
+++ b/offload/test/mapping/firstprivate_aligned.cpp
@@ -1,4 +1,5 @@
 // RUN: %libomptarget-compilexx-generic -O3 && %libomptarget-run-generic
+// XFAIL: intelgpu
 
 #include <stdio.h>
 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants