Revert "[Offload][lit] Link against SPIR-V DeviceRTL if present"#180211
Merged
Revert "[Offload][lit] Link against SPIR-V DeviceRTL if present"#180211
Conversation
)" This reverts commit b985974.
Member
|
@llvm/pr-subscribers-offload Author: Nick Sarnie (sarnex) ChangesNeed to make changes to buildbot first 1 Files Affected:
diff --git a/offload/test/lit.cfg b/offload/test/lit.cfg
index 898258f3e3cd0..0d5a9c95c1d95 100644
--- a/offload/test/lit.cfg
+++ b/offload/test/lit.cfg
@@ -166,8 +166,7 @@ elif config.operating_system == 'Darwin':
config.test_flags += " -Wl,-rpath," + config.library_dir
config.test_flags += " -Wl,-rpath," + config.omp_host_rtl_directory
else: # Unices
- if config.libomptarget_current_target != "nvptx64-nvidia-cuda" and \
- not config.libomptarget_current_target.startswith('spirv'):
+ if config.libomptarget_current_target != "nvptx64-nvidia-cuda":
config.test_flags += " -nogpulib"
config.test_flags += " -Wl,-rpath," + config.library_dir
config.test_flags += " -Wl,-rpath," + config.omp_host_rtl_directory
@@ -215,7 +214,7 @@ def add_libraries(source):
if "gpu" not in config.available_features:
return source
if "intelgpu" in config.available_features:
- # SPIR-V uses an out-of-tree linker and libc doesn't work.
+ # There is no DeviceRTL for Intel yet and libc doesn't work.
return source
if config.libomptarget_has_libc:
return source + " -Xoffload-linker -lc " + \
|
AlexisPerry
pushed a commit
to llvm-project-tlp/llvm-project
that referenced
this pull request
Feb 6, 2026
…m#180211) Reverts llvm#180030 Need to make changes to buildbot first
rishabhmadan19
pushed a commit
to rishabhmadan19/llvm-project
that referenced
this pull request
Feb 9, 2026
…m#180211) Reverts llvm#180030 Need to make changes to buildbot first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #180030
Need to make changes to buildbot first