[TwoAddressInstruction] Track MadeChange when eliminating REG_SEQUENCE#173535
Merged
TejaX-Alaghari merged 1 commit intollvm:mainfrom Jan 13, 2026
Merged
Conversation
TejaX-Alaghari
force-pushed
the
twoaddr-regsequence-madechange
branch
from
2057b7d to
77ace2e
Compare
TejaX-Alaghari
requested review from
arsenm,
cdevadas,
paperchalice and
vikramRH
cdevadas
approved these changes
Dec 25, 2025
arsenm
reviewed
Dec 26, 2025
| } | ||
|
|
||
| ++NumTwoAddressInstrs; | ||
| MadeChange = true; |
Contributor
There was a problem hiding this comment.
Wouldn't it be set down here?
Contributor
Author
There was a problem hiding this comment.
One corner case I can think of is -
If a function has only a REG_SEQUENCE and no other instructions with tied ops, collectTiedOperands() returns false, so we continue before reaching L#1899.
TejaX-Alaghari
force-pushed
the
twoaddr-regsequence-madechange
branch
from
77ace2e to
95656fe
Compare
Contributor
Author
|
Ping |
arsenm
approved these changes
Jan 12, 2026
c-rhodes
pushed a commit
that referenced
this pull request
Jan 13, 2026
#173535) When `eliminateRegSequence()` is called, the pass modifies the `MachineFunction` but `MadeChange` was not being set to true. This causes the pass to incorrectly return `PreservedAnalyses::all()` even though changes were made.
Priyanshu3820
pushed a commit
to Priyanshu3820/llvm-project
that referenced
this pull request
Jan 18, 2026
llvm#173535) When `eliminateRegSequence()` is called, the pass modifies the `MachineFunction` but `MadeChange` was not being set to true. This causes the pass to incorrectly return `PreservedAnalyses::all()` even though changes were made.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
eliminateRegSequence()is called, the pass modifies theMachineFunctionbutMadeChangewas not being set to true.This causes the pass to incorrectly return
PreservedAnalyses::all()even though changes were made.