[NFC][CodingStandard] Add additional example for if-else brace rule#111733
Merged
[NFC][CodingStandard] Add additional example for if-else brace rule#111733
Conversation
Add example to document that single statement `else` needs a brace if the associated `if` needs a brace.
erichkeane
reviewed
Oct 9, 2024
Collaborator
erichkeane
left a comment
erichkeane
left a comment
There was a problem hiding this comment.
I'm OK with this, but we need to see how the RFC goes before we can accept it.
Collaborator
|
I see this example as covering what the text already states:
The example sections is meant to illustrate the text, so LGTM here. |
Contributor
Author
Agreed. The example is meant as additional reinforcement as the first instinct might be to look at examples, and since this one is commonly violated, would help with an example. I'll let the thread sit for a week or 2 and if there are no concerns raised, we can commit this PR. |
jayfoad
approved these changes
Oct 10, 2024
Contributor
jayfoad
left a comment
jayfoad
left a comment
There was a problem hiding this comment.
Seems obviously fine to me for the reasons @joker-eph explained. I don't even think there's any need to wait a week or two.
rnk
approved these changes
Oct 10, 2024
Collaborator
rnk
left a comment
rnk
left a comment
There was a problem hiding this comment.
This example seems consistent with the policy to me.
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/123/builds/7356 Here is the relevant piece of the build log for the reference |
ichaer
added a commit
to splunk/ichaer-llvm-project
that referenced
this pull request
Oct 11, 2024
…ent-indentonly * llvm-trunk/main: (6379 commits) [gn build] Port 1c94388 [RISCV] Introduce VLOptimizer pass (llvm#108640) [mlir][vector] Add more tests for ConvertVectorToLLVM (7/n) (llvm#111895) [libc++] Add output groups to run-buildbot (llvm#111739) [libc++abi] Remove unused LIBCXXABI_LIBCXX_INCLUDES CMake option (llvm#111824) [clang] Ignore inline namespace for `hasName` (llvm#109147) [AArch64] Disable consecutive store merging when Neon is unavailable (llvm#111519) [lldb] Fix finding make tool for tests (llvm#111980) Turn `-Wdeprecated-literal-operator` on by default (llvm#111027) [AMDGPU] Rewrite RegSeqNames using !foreach. NFC. (llvm#111994) Revert "Reland: [clang] Finish implementation of P0522 (llvm#111711)" Revert "[clang] CWG2398: improve overload resolution backwards compat (llvm#107350)" Revert "[clang] Implement TTP P0522 pack matching for deduced function template calls. (llvm#111457)" [Clang] Replace Intrinsic::getDeclaration with getOrInsertDeclaration (llvm#111990) Revert "[NVPTX] Prefer prmt.b32 over bfi.b32 (llvm#110766)" [RISCV] Add DAG combine to turn (sub (shl X, 8-Y), (shr X, Y)) into orc.b (llvm#111828) [libc] Fix compilation of new trig functions (llvm#111987) [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (llvm#111752) [NFC][CodingStandard] Add additional example for if-else brace rule (llvm#111733) CodeGen: Remove redundant REQUIRES registered-target from tests (llvm#111982) ...
owenca
reviewed
Oct 12, 2024
| if (isa<FunctionDecl>(D)) { | ||
| verifyFunctionDecl(D); | ||
| handleFunctionDecl(D); | ||
| } else { |
Contributor
There was a problem hiding this comment.
I would add an else if single-statement block too.
Contributor
Author
There was a problem hiding this comment.
Sounds good, I'll amend the example to include an else if and an else.
DanielCChen
pushed a commit
to DanielCChen/llvm-project
that referenced
this pull request
Oct 16, 2024
…lvm#111733) Add example to document that single statement `else` needs a brace if the associated `if` needs a brace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add example to document that single statement
elseneeds a brace if the associatedifneeds a brace.