Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wshadow does not warn for static variables #62850

Closed
alexkaratarakis opened this issue May 22, 2023 · 1 comment
Closed

-Wshadow does not warn for static variables #62850

alexkaratarakis opened this issue May 22, 2023 · 1 comment
Assignees
@hazohelet
Labels
clang:diagnostics New/improved warning or error message in Clang, but not in clang-tidy or static analyzer confirmed Verified by a second party

Comments

@alexkaratarakis
Copy link

Min repro:

// Compile with -Wshadow
int main()
{
    static bool CONDITION = false;

    {
        static bool CONDITION = true;
    }
}

expected results: declaration of 'CONDITION' shadows a previous local [-Wshadow]
actual results: No warnings

gcc warns when the diagnostic is enabled, but clang does not.

Demo: https://godbolt.org/z/WjPTMvYP8
@tbaederr tbaederr added clang:diagnostics New/improved warning or error message in Clang, but not in clang-tidy or static analyzer and removed new issue labels May 22, 2023
@shafik shafik added the confirmed Verified by a second party label May 22, 2023
@hazohelet
Copy link
Member

Proposed fix: https://reviews.llvm.org/D151214

@hazohelet hazohelet self-assigned this May 23, 2023
veselypeta pushed a commit to veselypeta/cherillvm that referenced this issue Aug 23, 2024
@hazohelet @veselypeta
[clang][Sema] -Wshadow warns about shadowings by static local varia…
68fdf63 
…bles

This patch makes `-Wshadow` warn about the shadowings by static local variables.

Fixes llvm/llvm-project#62850
Differential Revision: https://reviews.llvm.org/D151214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hazohelet hazohelet

Labels
clang:diagnostics New/improved warning or error message in Clang, but not in clang-tidy or static analyzer confirmed Verified by a second party
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexkaratarakis @shafik @hazohelet @tbaederr