Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initializing a _Complex variable with an initializer list with too many items highlights the wrong item #61518

Closed
tbaederr opened this issue Mar 19, 2023 · 8 comments
Closed

Initializing a _Complex variable with an initializer list with too many items highlights the wrong item #61518

tbaederr opened this issue Mar 19, 2023 · 8 comments
Assignees
@chaitanyav
Labels
clang:diagnostics New/improved warning or error message in Clang, but not in clang-tidy or static analyzer clang:frontend Language frontend issues, e.g. anything involving "Sema" confirmed Verified by a second party good first issue https://github.com/llvm/llvm-project/contribute

Comments

@tbaederr
Copy link
Contributor

tbaederr commented Mar 19, 2023 •
edited
Loading

See:

constexpr _Complex double d = {1.0, 2.0, 3.0, 45};
constexpr  double e[2]      = {1.0, 2.0, 3.0, 45};

Godbolt: https://godbolt.org/z/P7vqM4dq9

Output:

<source>:3:37: error: excess elements in scalar initializer
constexpr _Complex double d = {1.0, 2.0, 3.0, 45};
                                    ^~~
<source>:4:42: error: excess elements in array initializer
constexpr  double e[2]      = {1.0, 2.0, 3.0, 45};
                                         ^~~

Clang highlights the second entry for the _Complex variable, but it should highlight the third I think.

I have other issues with the diagnostics here, but since this is about _Complex and that is a fringe feature anyway, I don't care much about those and fixing the off-by-one error should be enough.
@tbaederr tbaederr added good first issue https://github.com/llvm/llvm-project/contribute clang:frontend Language frontend issues, e.g. anything involving "Sema" clang:diagnostics New/improved warning or error message in Clang, but not in clang-tidy or static analyzer labels Mar 19, 2023
@llvmbot
Copy link
Member

llvmbot commented Mar 19, 2023

@llvm/issue-subscribers-clang-frontend

@llvmbot
Copy link
Member

llvmbot commented Mar 19, 2023

@llvm/issue-subscribers-good-first-issue

@chaitanyav
Copy link
Contributor

chaitanyav commented Mar 19, 2023 •
edited
Loading

@tbaederr I want to work on this

@shafik
Copy link
Collaborator

shafik commented Mar 19, 2023

Confirmed, I would note that gcc just points to the closing brace: https://godbolt.org/z/rahvaTTrs

@shafik shafik added the confirmed Verified by a second party label Mar 19, 2023
@tqkblx
Copy link
Contributor

tqkblx commented Mar 21, 2023 •
edited
Loading

https://reviews.llvm.org/D146503

@samuelmaina
Copy link
Contributor

@1lyasm I have seen that you have selected only a small section in your review. How do I select only the changed chunk in my review. I am asking for another issue not this one.

@tqkblx
Copy link
Contributor

tqkblx commented Mar 22, 2023

@samuelmaina I did git diff -U99999 > file_name.txt and uploaded the file to phabricator

@chaitanyav chaitanyav self-assigned this Mar 22, 2023
@samuelmaina
Copy link
Contributor

Thanks very much. I will do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chaitanyav chaitanyav

Labels
clang:diagnostics New/improved warning or error message in Clang, but not in clang-tidy or static analyzer clang:frontend Language frontend issues, e.g. anything involving "Sema" confirmed Verified by a second party good first issue https://github.com/llvm/llvm-project/contribute
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@chaitanyav @shafik @tbaederr @samuelmaina @llvmbot @tqkblx