Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang + -fms-extensions: __FUNCSIG__ is not a literal #114

Closed
Tracked by #11
vrubleg opened this issue Feb 3, 2020 · 8 comments
Closed
Tracked by #11

Clang + -fms-extensions: __FUNCSIG__ is not a literal #114

vrubleg opened this issue Feb 3, 2020 · 8 comments
Assignees
@aeubanks
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" clang-cl `clang-cl` driver. Don't use for other compiler parts

Comments

@vrubleg
Copy link

vrubleg commented Feb 3, 2020 •
edited
Loading

__FUNCSIG__ is a literal in MSVC, so you can write something like this:

char Data[] = __FUNCSIG__;

Clang with -fms-extensions specified can't compile it:

error: array initializer must be an initializer list or string literal
@RKSimon RKSimon added clang:frontend Language frontend issues, e.g. anything involving "Sema" clang-cl `clang-cl` driver. Don't use for other compiler parts labels Apr 12, 2022
@llvmbot
Copy link
Member

llvmbot commented Apr 12, 2022

@llvm/issue-subscribers-clang-frontend

@nico
Copy link
Contributor

nico commented May 4, 2022

dupe of #30933

@nico nico closed this as completed May 4, 2022
@vrubleg
Copy link
Author

vrubleg commented May 4, 2022

@nico but it seems like it is a different issue.

@nico
Copy link
Contributor

nico commented May 4, 2022

You're right, apologies.

@nico nico reopened this May 4, 2022
@doocman doocman mentioned this issue Jun 5, 2022
Open
@aeubanks aeubanks self-assigned this Jul 13, 2022
@TatyanaDoubts TatyanaDoubts mentioned this issue Nov 4, 2022
Closed
@aeubanks
Copy link
Contributor

https://reviews.llvm.org/D146764

@vrubleg
Copy link
Author

vrubleg commented May 7, 2023 •
edited
Loading

Thank you for fixing this.

TBH, it feels like this behavior should be default for all predefined string macros in both Clang and GCC, I don't see any reason why it shouldn't.

Anyway, it is at least available as an option in Clang.

@aeubanks
Copy link
Contributor

aeubanks commented May 9, 2023

patch was reverted, reopening

@aeubanks aeubanks reopened this May 9, 2023
@aeubanks
Copy link
Contributor

aeubanks commented May 9, 2023

for why this isn't a string literal normally, that's a spec requirement: https://stackoverflow.com/questions/4384765/whats-the-difference-between-pretty-function-function-func

@Bouncner Bouncner mentioned this issue Jun 12, 2023
Closed
@nilres nilres mentioned this issue May 28, 2024
Closed
RevySR pushed a commit to revyos/llvm-project that referenced this issue Jul 27, 2024
@imkiva
[Clang][XTHeadVector] Implement 14.16-14.18 vf{n,w}cvt (llvm#114)
962c56c 
* [Clang][XTHeadVector] Implement 14.16-14.18 `vf{n,w}cvt`

* [Clang][XTHeadVector] Test 14.16-14.18 `vf{n,w}cvt`

* [Clang][XTHeadVector] Implement & Test `vfwcvt_f`

* [Clang][XTHeadVector] Implement wrappers for 14.16-14.18
@usx95 usx95 mentioned this issue Sep 6, 2024
Closed
SpencerAbson added a commit that referenced this issue Nov 8, 2024
@SpencerAbson
Revert "[AArch64] Reduce +sve2-aes to an alias of +sve-aes+sve2 (#114… (
bbcd352 
#115539)

…293)"

This reverts commit da9499e.
Groverkss pushed a commit to iree-org/llvm-project that referenced this issue Nov 15, 2024
@SpencerAbson @Groverkss
Revert "[AArch64] Reduce +sve2-aes to an alias of +sve-aes+sve2 (llvm…
132f8b2 
…#114… (llvm#115539)

…293)"

This reverts commit da9499e.
michalpaszkowski added a commit that referenced this issue Dec 12, 2024
@michalpaszkowski
Revert "[LoadStoreVectorizer] Postprocess and merge equivalence class…
7e60d79 
…es (#114…"

This reverts commit fd2f8d4.
@paulhuggett paulhuggett mentioned this issue Jan 6, 2025
Merged
@piyushhingu piyushhingu mentioned this issue Apr 2, 2025
Open
@damyanp damyanp mentioned this issue Apr 1, 2025
Open
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeubanks aeubanks

Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" clang-cl `clang-cl` driver. Don't use for other compiler parts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nico @vrubleg @RKSimon @aeubanks @llvmbot