[CSSPGO] Fix a typo in SampleContextTracker

htyu · htyu · commit ab5ac659c81a · 2021-07-22T16:44:50.000-07:00
Fixing a typo in SampleContextTracker to use debug name when debug linkage name is no present. This should only affect C programs. Saw 0.6% perf win on Cinder which is mostly C code. Reviewed By: wenlei, wmi Differential Revision: https://reviews.llvm.org/D106599
diff --git a/llvm/lib/Transforms/IPO/SampleContextTracker.cpp b/llvm/lib/Transforms/IPO/SampleContextTracker.cpp
@@ -433,8 +433,7 @@ ContextTrieNode *SampleContextTracker::getContextFor(const DILocation *DIL) {
     if (Name.empty())
       Name = PrevDIL->getScope()->getSubprogram()->getName();
     S.push_back(
-        std::make_pair(FunctionSamples::getCallSiteIdentifier(DIL),
-                       PrevDIL->getScope()->getSubprogram()->getLinkageName()));
+        std::make_pair(FunctionSamples::getCallSiteIdentifier(DIL), Name));
     PrevDIL = DIL;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -433,8 +433,7 @@ ContextTrieNode SampleContextTracker::getContextFor(const DILocation DIL) {`
`433`	`433`	`if (Name.empty())`
`434`	`434`	`Name = PrevDIL->getScope()->getSubprogram()->getName();`
`435`	`435`	`S.push_back(`
`436`		`- std::make_pair(FunctionSamples::getCallSiteIdentifier(DIL),`
`437`		`- PrevDIL->getScope()->getSubprogram()->getLinkageName()));`
	`436`	`+ std::make_pair(FunctionSamples::getCallSiteIdentifier(DIL), Name));`
`438`	`437`	`PrevDIL = DIL;`
`439`	`438`	`}`
`440`	`439`