@hainest: great to see you again obviously :-). So we never declared this code base support latest C++ like 17. So some questions when you remove throw construct but still an exception occurs, what happens?

So some questions when you remove throw construct but still an exception occurs, what happens?

void foo() { throw X{};} and void foo() throw(X) { throw X{}; } have had identical behavior since C++98. The standard never required that compilers check that a function only throws a given exception type. In fact, there are cases where such a check is impossible. That is why it was removed.

There are two points to consider:

1. void foo() throw() {} and void foo() noexcept {} have identical behavior. If an exception escapes foo (e.g., it doesn't catch all exceptions thrown by functions it calls), then std::terminate is called and the program will abort. I didn't see any usage of empty throw specifications (throw()) or noexcept, so this won't be an issue right now.

2. Starting in C++17, noexcept is now part of the type system. This means that taking pointers to noexcept functions works differently.

void do_call_noexcept(void (*)(int) noexcept) {}
void do_call(void (*)(int)) {}

void foo(int) {}
void bar(int) noexcept {}

int main() {
    do_call(&foo);  // compiles
    do_call(&bar);  // compiles

    do_call_noexcept(&foo);  // Error! type mismatch
    do_call_noexcept(&bar);  // compiles
}

Neither of these is happening in the code base right now, but they are something to consider for the future.

@lee218llnl Dong mentioned you would be a good contact for updates to this repo. Could you take a look at this? Thanks!

@hainest and @dongahn, I'm not up to date on my C++ programming, so I'm not particularly qualified to review this. @mplegendre may also be able to lend an eye too. Otherwise, you'll have to wait for me to get time to catch up on C++ standards.

@lee218llnl Not a problem. Let me know if you have any questions.