Repository navigation
Commit 9532969
committed
[Robustness]
When object-valued input to `parse` contains a nested object whose own keys include `__proto__`
(e.g. from `JSON.parse('{"__proto__":...}')`,
which creates an own data property via CreateDataProperty),
the `acc[key] = value` assignment in `merge`/`assign` invoked the `Object.prototype.__proto__` accessor and mutated the per-call returned sub-object's [[Prototype]].
This is not `Object.prototype` pollution - it affects only the returned sub-object, and downstream consumers can guard with `hasOwnProperty` or `plainObjects: true` - but the setter firing as a side effect of property copying is a footgun that the
string-input path has long guarded against (see `parseObject`'s `decodedRoot !== '__proto__'` check).
Use `Object.defineProperty` for `__proto__` keys so an own data property is created instead.utils.merge / utils.assign: avoid invoking __proto__ setter when copying own properties1 parent 9aca407 commit 9532969
3 files changed
Lines changed: 34 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| |||
66 | 67 | | |
67 | 68 | | |
68 | 69 | | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
69 | 83 | | |
70 | 84 | | |
71 | 85 | | |
| |||
145 | 159 | | |
146 | 160 | | |
147 | 161 | | |
148 | | - | |
| 162 | + | |
149 | 163 | | |
150 | | - | |
| 164 | + | |
151 | 165 | | |
152 | 166 | | |
153 | 167 | | |
| |||
166 | 180 | | |
167 | 181 | | |
168 | 182 | | |
169 | | - | |
| 183 | + | |
170 | 184 | | |
171 | 185 | | |
172 | 186 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| 34 | + | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
959 | 959 | | |
960 | 960 | | |
961 | 961 | | |
| 962 | + | |
| 963 | + | |
| 964 | + | |
| 965 | + | |
| 966 | + | |
| 967 | + | |
| 968 | + | |
| 969 | + | |
| 970 | + | |
| 971 | + | |
| 972 | + | |
| 973 | + | |
| 974 | + | |
| 975 | + | |
| 976 | + | |
| 977 | + | |
962 | 978 | | |
963 | 979 | | |
964 | 980 | | |
| |||
0 commit comments