You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 6b21603
Browse filesBrowse the repository at this point in the historyBrowse files
fix(ipc): coordinate close with in-flight initialize and accept shutdown-before-init
Two gaps found by an automated review of the previous commit:
aclose() racing a still-running (not cancelled) initialize() resolved the
initialize future under the pending response read, starting the monitor
task as a second reader of the duplex (a concurrent-read RuntimeError that
also failed aclose()), and initialize() then crashed double-setting the
already-failed future. aclose() now stops the tracked in-flight read
first, and initialize() guards its future writes.
aclose() without initialize() made the ShutdownRequest the runner's
first message, which died on its "first message must be
InitializeRequest" assert (an uncaught exception in the runner thread)
while the executor reported SUCCESS. The proc client now accepts an
initial ShutdownRequest and the runners exit cleanly.
0 commit comments