Skip to content

Conversation

@FathyMuhamed
Copy link
Contributor

@FathyMuhamed FathyMuhamed commented Mar 26, 2025

What type of PR is this? (check all applicable)

Add Editor Theme Command to Command Menu

  • ✨ Feature

Description

This PR adds a new command menu item that allows users to quickly access the editor theme settings. When selected, it opens the editor settings panel and automatically scrolls to the theme selector for better user experience.

image

@netlify
Copy link

netlify bot commented Mar 26, 2025

Deploy Preview for livecodes ready!

Name Link
🔨 Latest commit 191a0b0
🔍 Latest deploy log https://app.netlify.com/sites/livecodes/deploys/67e4d548b6ca6400084bfbe7
😎 Deploy Preview https://deploy-preview-775--livecodes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarqubecloud
Copy link

@hatemhosny
Copy link
Collaborator

Thank you @FathyMuhamed

This is a nice addition.

I have made some changes:

  • We already have a function that shows screens and allows scroll to specific elements. I made that available in command menu actions.
  • I placed the command menu action inside the category "Change Theme ..." for consistency.
  • We do not add translations manually. We use Lokalise. Please see the guide for translations.
    In summary: for strings in typescript, use window.deps.translateString like you did, then run npm run i18n-export before you commit. After we merge the PR, the new keys are synchronized to Lokalise. We add the translations there then sync back to GitHub.
  • In this case I just reused the key editorSettings.editorTheme, so no new translations are required.

Generally when you want to make some changes, let's discuss that in an issue first, so that we can agree on the approach. I may also be able to guide.

Please review the changes and let me know what you think.
Thank you very much.

@FathyMuhamed
Copy link
Contributor Author

FathyMuhamed commented Mar 27, 2025

@hatemhosny Really thank you very much for clarifying all of this, I just found that I have been searching for a while to change the theme so I started working on it to be better but after that we can discuss the changes first thank you again

@hatemhosny
Copy link
Collaborator

I will merge this now.

Looking forward for your next contribution 🌹

@hatemhosny hatemhosny merged commit 4f9ede1 into live-codes:develop Mar 27, 2025
14 checks passed
@hatemhosny
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants