Skip to content

Conversation

@FathyMuhamed
Copy link
Contributor

What type of PR is this? (check all applicable)

  • 🎨 Style

Description

Replace static loading logo with an animated SVG spinner to improve user feedback during application initialization. The implementation uses a clean, branded loading animation that provides better visual indication of loading status without requiring JavaScript to unhide elements.

before:

Screen.Recording.2025-03-21.at.12.51.49.AM.mov

after:

Screen.Recording.2025-03-21.at.12.53.37.AM.mov

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentations?

  • 📓 docs (./docs)
  • 📕 storybook (./storybook)
  • 📜 README.md
  • 🙅 no documentation needed

@netlify
Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for livecodes ready!

Name Link
🔨 Latest commit 1d77332
🔍 Latest deploy log https://app.netlify.com/sites/livecodes/deploys/67df307f97eb3d000837d447
😎 Deploy Preview https://deploy-preview-768--livecodes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hatemhosny
Copy link
Collaborator

hatemhosny commented Mar 21, 2025

Thank you, @FathyMuhamed

I like this. It is indeed an improvement.

I have some comments/suggestions:

  • Let's try/explore other animations e.g. bounce, pulse effect with changing size or something like this. We can use LiveCodes for demos (e.g. https://livecodes.io/?x=id/vnqj3f3s7wa)
  • I think we should keep the loading text (but remove the SVG spinner). This would be specially useful for embedded playgrounds, so that users would know what they are expecting to load.
  • I originally linked to livecodes-logo.svg because it is being used again in the app header. But since the loading image is not used again, we may just inline it as svg element in the html page (like we do with CSS) and get rid of the extra network request. At this point we need to show something to the user as fast as possible.
  • We need to consider minifying this html page in the build step, specially after inlining the svg image. (I can do that)

Please let me know what you think.
Thanks again :)

@FathyMuhamed
Copy link
Contributor Author

@hatemhosny first thank you for your comments and suggestions!

I’ve worked on two more SVG animations—could you review them and help me choose the best one? I’m leaning toward the second option

Suggestion1: https://livecodes.io/?x=id/ufhm7qexbpj

Suggestion2: https://livecodes.io/?x=id/53e2bkqp7xv

@hatemhosny
Copy link
Collaborator

@hatemhosny first thank you for your comments and suggestions!

I’ve worked on two more SVG animations—could you review them and help me choose the best one? I’m leaning toward the second option

Suggestion1: https://livecodes.io/?x=id/ufhm7qexbpj

Suggestion2: https://livecodes.io/?x=id/53e2bkqp7xv

I also prefer the second one 👍

@hatemhosny
Copy link
Collaborator

@sonarqubecloud
Copy link

@FathyMuhamed
Copy link
Contributor Author

FathyMuhamed commented Mar 22, 2025

@hatemhosny After update animation 👍🏻

Screen.Recording.2025-03-22.at.11.48.02.PM.mov

@hatemhosny
Copy link
Collaborator

Thank you, @FathyMuhamed
That looks nice.

I will merge this now and then I will implement HTML minification in a separate PR, isA.

Thank you :)

@hatemhosny hatemhosny merged commit e2c5e48 into live-codes:develop Mar 23, 2025
15 checks passed
@hatemhosny
Copy link
Collaborator

This is now on the development build on: https://dev.livecodes.io/

It will be on the main website in the next release isA.

Thank you 🌹

@hatemhosny hatemhosny mentioned this pull request Mar 24, 2025
@hatemhosny
Copy link
Collaborator

@FathyMuhamed
HTML minification was implemented in #774 , in addition to a few CSS tweaks for compatibility with embedded playgrounds.
Thank you.

@hatemhosny
Copy link
Collaborator

@FathyMuhamed

I have slightly modified the loading logo.
Demo: https://livecodes.io/?x=id/i86m73rkixq

Please have a look and let me know what you think.

@FathyMuhamed
Copy link
Contributor Author

@hatemhosny It is very amazing now, thanks for your wonderful work 🚀

@hatemhosny
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants