Unify logic for pure and non-pure enums #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
commented
Mar 9, 2023
| return E; | ||
| }(E || {}); | ||
| E = /*#__PURE__*/function (E) { | ||
| E = function (E) { |
Author
There was a problem hiding this comment.
This was not needed, terser doesn't remove used variables (E) anyway.
Owner
There was a problem hiding this comment.
I'm inclined to keep it, maybe in the future terser can be implemented or other compressors can be used?
nicolo-ribaudo
commented
Mar 9, 2023
| (function (E) {})(E || (E = {})); | ||
| let E = /*#__PURE__*/function (E) { | ||
| return E; | ||
| }({}); |
Author
There was a problem hiding this comment.
Now terser can remove this :)
Owner
|
Thanks! It's all really good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2This is similar to what I suggested in babel#15467 (comment): it unifies the code path for the "pure" and "non pure" versions, so that we avoid having two different but very similar cases.
Instead of always generating the variable declaration followed by the IIFE, which as you pointed out doesn't work, I took the opposite approach and always generate the declaration with the IIFE as the initializer. It has the unfortunate side effect that
let X = (function () {})(X || {})is not valid (becauseXis in TDZ), so we must instead generatelet X = (function () {})({})in this case.