fix: v0.34.2 — stall auto-cancel, /cancel standalone fallback (#99)#100
Merged
Nathan Schram (nathanschram) merged 2 commits intomasterfrom Mar 8, 2026
Merged
Conversation
- Stall auto-cancel: dead process detection (immediate), no-PID zombie cap (3 warnings), absolute cap (10 warnings). Closes signal stream on auto-cancel so _run_loop exits cleanly. - Early PID threading: last_pid set at subprocess spawn, polled by run_runner_with_cancel before StartedEvent arrives. - Standalone /cancel: cancels single active run without requiring reply; prompts when multiple runs active; falls back to queued jobs. - queued_for_chat() on ThreadScheduler for standalone cancel of queued jobs. - Docs: watchdog config reference, changelog, CLAUDE.md test counts. Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Nathan Schram (nathanschram)
deleted the
fix/stall-auto-cancel-and-cancel-ux
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes zombie stall monitor loop after laptop sleep and improves
/cancelUX.last_pidset at subprocess spawn, polled beforeStartedEventarrives so stall monitor has PID for diagnostics./cancel: cancels single active run without requiring reply to progress message. Prompts when multiple runs active. Falls back to queued jobs via newqueued_for_chat().[watchdog]config reference, changelog v0.34.2, CLAUDE.md test counts.Closes #99
Test plan
uv run pytest— 1469 passed, 80.44% coverageuv run ruff check src/ && uv run ruff format --check src/ tests/uv lock --check@untether_dev_bot— standalone/cancelworked for active runs, "nothing running" for completed🤖 Generated with Claude Code