Repository navigation
Server-side sessions and unified session backends - #630
Merged
provinzkraut merged 66 commits intoOct 27, 2022
Merged
Conversation
|
This pull request introduces 4 alerts when merging f19f9d2 into d11d0fb - view on LGTM.com new alerts:
|
provinzkraut
marked this pull request as ready for review
October 26, 2022 15:43
provinzkraut
requested review from
Goldziher,
cofin,
infohash,
jtraub,
peterschutt and
seladb
October 26, 2022 15:43
provinzkraut
changed the title
Goldziher
reviewed
Oct 26, 2022
Goldziher
left a comment
Goldziher
left a comment
Contributor
There was a problem hiding this comment.
All in all, very impressive. There is still some work to be done.
Contributor
|
Is it possible to have an extension API to use client side session as complementary? It will help a lot for extensions that manage user authentication and delegation of authority on APIs. |
Member
Author
I'm still not entirely sure what you mean by this. How would complementary session backends work API wise? And what would the use case be? If the identity is being managed by a different mechanism, it could effectively also just be an arbitrary storage like redis. So why would one want to use this? |
Goldziher
approved these changes
Oct 26, 2022
jtraub
reviewed
Oct 26, 2022
…ends. Integrate backends with existing tests
…nds. Integrate backends with existing tests
…nds. Integrate backends with existing tests
* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Goldziher
reviewed
Oct 27, 2022
Goldziher
reviewed
Oct 27, 2022
Goldziher
reviewed
Oct 27, 2022
Goldziher
reviewed
Oct 27, 2022
Goldziher
reviewed
Oct 27, 2022
Goldziher
reviewed
Oct 27, 2022
Goldziher
reviewed
Oct 27, 2022
Goldziher
approved these changes
Oct 27, 2022
Co-authored-by: Na'aman Hirschfeld <[email protected]>
Co-authored-by: Na'aman Hirschfeld <[email protected]>
Co-authored-by: Na'aman Hirschfeld <[email protected]>
Co-authored-by: Na'aman Hirschfeld <[email protected]>
Co-authored-by: Na'aman Hirschfeld <[email protected]>
Co-authored-by: Na'aman Hirschfeld <[email protected]>
Co-authored-by: Na'aman Hirschfeld <[email protected]>
Co-authored-by: Na'aman Hirschfeld <[email protected]>
Co-authored-by: Na'aman Hirschfeld <[email protected]>
A bug was introduced as part of #626, that would lower case header values
provinzkraut
added a commit
that referenced
this pull request
Oct 28, 2022
This was supported in the previous SessionMiddleware and was erroneously removed in #630. Test have been added.
2 of 4 tasks
provinzkraut
added a commit
that referenced
this pull request
Oct 28, 2022
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit WIP. Aims to implement #617
PR Checklist
CONTRIBUTING.md?