Remove the empty root repo from the release workflow. by bicknellr · Pull Request #2729 · lit/lit

bicknellr · 2022-04-13T21:30:14Z

This removes the empty root repo and tells changesets/action not to set the git user in the repo it's working on, which we already do at the beginning of the workflow.

Fixes #2542.

This should no longer be necessary as of `changesets/[email protected]`, which includes <changesets/action#161>.

changeset-bot · 2022-04-13T21:30:16Z

⚠️ No Changeset found

Latest commit: 9b0e168

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2022-04-13T21:30:36Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -7% - +13% (-2.16ms - +4.35ms)
^{this-change vs tip-of-tree}

render

lit-element-list: unsure 🔍 -0% - +3% (-0.37ms - +2.44ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -3% - +2% (-1.06ms - +0.60ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -0% - +4% (-0.05ms - +0.54ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -1% - +3% (-0.64ms - +2.17ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -15% - +13% (-12.66ms - +11.39ms)
^{this-change vs tip-of-tree}

update

lit-element-list: unsure 🔍 -2% - +5% (-19.18ms - +50.95ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -6% - +9% (-6.02ms - +9.73ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -4% - +9% (-17.07ms - +36.15ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -3% - +2% (-4.17ms - +3.11ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -6% - +19% (-79.35ms - +242.86ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: unsure 🔍 -1% - +1% (-7.75ms - +9.52ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +3% (-12.18ms - +31.86ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 100.0.4896.75
Sample size: 50
Built by: Benchmarks #2714
Commit: 0df05e4

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	88.85ms - 91.23ms	-	unsure 🔍 -0% - +3% -0.37ms - +2.44ms	faster ✔ 16% - 20% 17.81ms - 21.88ms
tip-of-tree tip-of-tree	88.26ms - 89.74ms	unsure 🔍 -3% - +0% -2.44ms - +0.37ms	-	faster ✔ 18% - 20% 19.07ms - 22.69ms
previous-release previous-release	108.23ms - 111.53ms	slower ❌ 20% - 24% 17.81ms - 21.88ms	slower ❌ 21% - 26% 19.07ms - 22.69ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	919.27ms - 982.37ms	-	unsure 🔍 -2% - +5% -19.18ms - +50.95ms	faster ✔ 33% - 37% 473.00ms - 542.44ms
tip-of-tree tip-of-tree	919.65ms - 950.23ms	unsure 🔍 -5% - +2% -50.95ms - +19.18ms	-	faster ✔ 35% - 37% 502.55ms - 544.66ms
previous-release previous-release	1444.07ms - 1473.02ms	slower ❌ 48% - 59% 473.00ms - 542.44ms	slower ❌ 53% - 59% 502.55ms - 544.66ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	893.90ms - 907.32ms	-	unsure 🔍 -1% - +1% -7.75ms - +9.52ms	faster ✔ 7% - 9% 70.58ms - 91.84ms
tip-of-tree tip-of-tree	894.29ms - 905.15ms	unsure 🔍 -1% - +1% -9.52ms - +7.75ms	-	faster ✔ 7% - 9% 72.23ms - 91.96ms
previous-release previous-release	973.58ms - 990.06ms	slower ❌ 8% - 10% 70.58ms - 91.84ms	slower ❌ 8% - 10% 72.23ms - 91.96ms	-

lit-html-kitchen-sink

Browser: chrome-headless 100.0.4896.75
Sample size: 30
Built by: Benchmarks #2714
Commit: 0df05e4

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	35.77ms - 36.47ms	-	unsure 🔍 -3% - +2% -1.06ms - +0.60ms	faster ✔ 15% - 22% 6.16ms - 10.09ms
tip-of-tree tip-of-tree	35.60ms - 37.11ms	unsure 🔍 -2% - +3% -0.60ms - +1.06ms	-	faster ✔ 14% - 22% 5.82ms - 9.97ms
previous-release previous-release	42.31ms - 46.19ms	slower ❌ 17% - 28% 6.16ms - 10.09ms	slower ❌ 16% - 28% 5.82ms - 9.97ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	100.24ms - 110.52ms	-	unsure 🔍 -6% - +9% -6.02ms - +9.73ms	unsure 🔍 -5% - +7% -5.67ms - +7.55ms
tip-of-tree tip-of-tree	97.57ms - 109.49ms	unsure 🔍 -9% - +6% -9.73ms - +6.02ms	-	unsure 🔍 -8% - +6% -8.18ms - +6.35ms
previous-release previous-release	100.29ms - 108.60ms	unsure 🔍 -7% - +5% -7.55ms - +5.67ms	unsure 🔍 -6% - +8% -6.35ms - +8.18ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	31.08ms - 36.67ms	-	unsure 🔍 -7% - +13% -2.16ms - +4.35ms	unsure 🔍 -16% - +1% -5.95ms - +0.40ms
tip-of-tree tip-of-tree	31.10ms - 34.46ms	unsure 🔍 -13% - +6% -4.35ms - +2.16ms	-	faster ✔ 5% - 16% 1.61ms - 6.13ms
previous-release previous-release	35.14ms - 38.16ms	unsure 🔍 -2% - +18% -0.40ms - +5.95ms	slower ❌ 4% - 19% 1.61ms - 6.13ms	-

lit-html-repeat

Browser: chrome-headless 100.0.4896.75
Sample size: 30
Built by: Benchmarks #2714
Commit: 0df05e4

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	13.06ms - 13.53ms	-	unsure 🔍 -0% - +4% -0.05ms - +0.54ms	faster ✔ 6% - 11% 0.90ms - 1.58ms
tip-of-tree tip-of-tree	12.86ms - 13.23ms	unsure 🔍 -4% - +0% -0.54ms - +0.05ms	-	faster ✔ 8% - 12% 1.18ms - 1.79ms
previous-release previous-release	14.29ms - 14.78ms	slower ❌ 7% - 12% 0.90ms - 1.58ms	slower ❌ 9% - 14% 1.18ms - 1.79ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	408.19ms - 445.79ms	-	unsure 🔍 -4% - +9% -17.07ms - +36.15ms	faster ✔ 17% - 26% 89.87ms - 140.96ms
tip-of-tree tip-of-tree	398.61ms - 436.28ms	unsure 🔍 -8% - +4% -36.15ms - +17.07ms	-	faster ✔ 19% - 27% 99.38ms - 150.53ms
previous-release previous-release	525.10ms - 559.70ms	slower ❌ 20% - 34% 89.87ms - 140.96ms	slower ❌ 23% - 37% 99.38ms - 150.53ms	-

lit-html-template-heavy

Browser: chrome-headless 100.0.4896.75
Sample size: 50
Built by: Benchmarks #2714
Commit: 0df05e4

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	65.25ms - 67.23ms	-	unsure 🔍 -1% - +3% -0.64ms - +2.17ms	faster ✔ 14% - 18% 11.21ms - 14.44ms
tip-of-tree tip-of-tree	64.48ms - 66.47ms	unsure 🔍 -3% - +1% -2.17ms - +0.64ms	-	faster ✔ 15% - 19% 11.97ms - 15.21ms
previous-release previous-release	77.78ms - 80.34ms	slower ❌ 17% - 22% 11.21ms - 14.44ms	slower ❌ 18% - 23% 11.97ms - 15.21ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	147.45ms - 152.60ms	-	unsure 🔍 -3% - +2% -4.17ms - +3.11ms	faster ✔ 11% - 14% 18.07ms - 25.01ms
tip-of-tree tip-of-tree	147.98ms - 153.12ms	unsure 🔍 -2% - +3% -3.11ms - +4.17ms	-	faster ✔ 10% - 14% 17.54ms - 24.48ms
previous-release previous-release	169.24ms - 173.89ms	slower ❌ 12% - 17% 18.07ms - 25.01ms	slower ❌ 11% - 16% 17.54ms - 24.48ms	-

reactive-element-list

Browser: chrome-headless 100.0.4896.75
Sample size: 50
Built by: Benchmarks #2714
Commit: 0df05e4

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	76.60ms - 93.40ms	-	unsure 🔍 -15% - +13% -12.66ms - +11.39ms	unsure 🔍 -20% - +5% -18.86ms - +5.14ms
tip-of-tree tip-of-tree	77.02ms - 94.24ms	unsure 🔍 -13% - +15% -11.39ms - +12.66ms	-	unsure 🔍 -20% - +6% -18.37ms - +5.92ms
previous-release previous-release	83.29ms - 100.43ms	unsure 🔍 -7% - +23% -5.14ms - +18.86ms	unsure 🔍 -7% - +22% -5.92ms - +18.37ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1273.81ms - 1497.84ms	-	unsure 🔍 -6% - +19% -79.35ms - +242.86ms	unsure 🔍 -5% - +21% -56.46ms - +262.34ms
tip-of-tree tip-of-tree	1188.28ms - 1419.87ms	unsure 🔍 -17% - +5% -242.86ms - +79.35ms	-	unsure 🔍 -11% - +14% -140.89ms - +183.26ms
previous-release previous-release	1169.49ms - 1396.29ms	unsure 🔍 -19% - +4% -262.34ms - +56.46ms	unsure 🔍 -14% - +11% -183.26ms - +140.89ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	971.07ms - 1002.04ms	-	unsure 🔍 -1% - +3% -12.18ms - +31.86ms	unsure 🔍 -1% - +3% -9.74ms - +32.16ms
tip-of-tree tip-of-tree	961.05ms - 992.37ms	unsure 🔍 -3% - +1% -31.86ms - +12.18ms	-	unsure 🔍 -2% - +2% -19.71ms - +22.44ms
previous-release previous-release	961.24ms - 989.45ms	unsure 🔍 -3% - +1% -32.16ms - +9.74ms	unsure 🔍 -2% - +2% -22.44ms - +19.71ms	-

_{tachometer-reporter-action v2 for Benchmarks}

bicknellr · 2022-04-13T21:33:09Z

Also, what title prefix should I use for these kinds of PRs? Maybe "[meta]" or "[infra]"?

aomarks · 2022-04-13T21:37:43Z

.github/workflows/release.yaml

          # The `working-directory` option is only available for steps that use
          # `run`. This `cwd` option is the same, but specific to this action.
          cwd: lit
+          setupGitUser: false


Add comment explaining this?

bicknellr added 4 commits March 15, 2022 10:12

Remove the empty root repo in the release workflow. (...)

259b61f

This should no longer be necessary as of `changesets/[email protected]`, which includes <changesets/action#161>.

Merge remote-tracking branch 'origin/main' into remove-empty-root-repo

c2e63a1

Merge remote-tracking branch 'origin/main' into remove-empty-root-repo

00f47ff

Set setupGitUser: false on changesets/action.

44c737d

bicknellr requested a review from justinfagnani as a code owner April 13, 2022 21:30

bicknellr requested review from aomarks and rictic April 13, 2022 21:36

aomarks requested changes Apr 13, 2022

View reviewed changes

Add a comment for setupGitUser: false.

9b0e168

aomarks approved these changes Apr 13, 2022

View reviewed changes

bicknellr merged commit 5657bc7 into main Apr 13, 2022

bicknellr deleted the remove-empty-root-repo branch April 13, 2022 23:15

augustjk mentioned this pull request Apr 29, 2022

[meta] Release PR CLA fails #2711

Closed

Conversation

bicknellr commented Apr 13, 2022

Uh oh!

changeset-bot bot commented Apr 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Apr 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

bicknellr commented Apr 13, 2022

Uh oh!

aomarks Apr 13, 2022

Choose a reason for hiding this comment

Uh oh!

bicknellr Apr 13, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot bot commented Apr 13, 2022 •

edited

Loading

github-actions bot commented Apr 13, 2022 •

edited

Loading