Add type keyword to export to avoid runtime class exports#747
Conversation
|
Hey Karl, This was like this before the recent changes. Do you want to revert this back? |
|
I'm not sure what tsc / tsdown needs to get the Currently, export { ... TaskWrapper as ListrTaskWrapper, ... }I was just thinking that maybe the Alternatively, as I wrote above, if this approach doesn't work, then I could imagine that maybe |
|
Let us give it a try since it is nothing descructive. |
|
If CI could show us the results of Example of CodeSandbox CI here: This empty object in For listr2, probably the |
|
But yeah, since this is already merged, I'll keep an eye on the releases and test out the next version, maybe |
|
@cenk1cenk2 I tried the build out locally, to avoid waiting for the published version, and it still doesn't add the But this version looks like it works: |
|
🎉 This PR is included in version 9.0.3 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.0.3 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.0.3 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.0.3 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Closes #745
Maybe this is what tsc / tsdown need to get the
typekeyword into the export indist/index.d.ts, via one of:export type { TaskWrapper as ListrTaskWrapper };export { type TaskWrapper as ListrTaskWrapper };If this approach doesn't work, then maybe
TaskWrapper as ListrTaskWrapperis exported somewhere else in the codebase as class?