Merged
Conversation
Contributor
|
I am a bot, here are the test results for this PR:
|
Member
Author
|
I need to merge this and it is my own fault for putting sealskin.app up before this was merged. I got two pings about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't get it done with sh for a bunch of if logic and string generation so needed to force bash.
This is an external helper to automate SSL generation and get the user setup for 90 days.
Further down the line I will expand this with renewal options, but I can only get back "cert does not need to be renewed" exit code basically now so waiting for a true loop even though the logic is likely sound.
Given Firefox, Android, and iOS need a legit domain and cert this is an easy gateway path for a user with nothing and no knowledge of reverse proxies.
I used the external duckdns container vs SWAG as it is made to oneshot, would it make sense to manual exec certonly with a swag container or open to opinions there.