Validate yaml #4169
Merged
Validate yaml #4169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Avi Deitcher <[email protected]>
Signed-off-by: Avi Deitcher <[email protected]>
deitch
force-pushed
the
validate-yaml
branch
from
379dd58 to
98bbfad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added yaml validation to
lkt pkg buildandlkt build. It already would report errors on required fields that were missing, and fields with wrong types. But extraneous fields that are unknown would be ignored silently.This looked ok, except it led to people getting stuck on minor typos that are not immediately visible, wasting hours debugging; or adding fields that do not exist and wondering why it doesn't work.
There was no reason not to require only known fields, and plenty of good reasons to do so.
Added tests of course.
Added in 2 separate commits.
- How I did it
Added yaml.v3 KnownFields validation. And added tests.
- How to verify it
CI
- Description for the changelog
Full yaml validation for pkg build and build