add support for dynamically calculated build arg sets #4156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Note that I have yet to add the actual tests for this change. They are coming shortly. I wanted CI to make sure I didn't break anything while I did it. |
deitch
force-pushed
the
dynamic-calculated-build-args
branch
8 times, most recently
from
2ba5b01 to
07d7c7b
Compare
Signed-off-by: Avi Deitcher <[email protected]>
deitch
force-pushed
the
dynamic-calculated-build-args
branch
from
07d7c7b to
5fcdad7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Following on from #4155 which added support to calculated build args using:
This adds multiple dynamic packages with
@lkt:pkgs:/path/to/*via:It is explained in more detail in the docs, also included in this PR. In short, everything in the glob path will be treated as a package dir, have its
show-tagresolved. It then will create multiple build-args, where each one has:lkt pkg show-tag <dir>%replaced with the name of the image in the directory, upper-cased, with characters/,-,:converted to_- How I did it
Changed the
TransformBuildArgValue()func from what already existed, added docs, added tests.- How to verify it
CI
- Description for the changelog
Dynamic calculated build args