add support for custom build args #4155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deitch
force-pushed
the
calculated-build-args
branch
10 times, most recently
from
2419219 to
75bb14a
Compare
Signed-off-by: Avi Deitcher <[email protected]>
deitch
force-pushed
the
calculated-build-args
branch
from
75bb14a to
d5a30f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added support for custom build args via the files. See the added section in
docs/packages.mdfor how to use.Also added support for the first custom build arg
@lkt:pkg:.And of course added tests!
- How I did it
build-arg-fileandbuild.ymlsectionbuildArgs- How to verify it
CI
- Description for the changelog
Support for calculated build args