Skip to content

provide mirror support #4148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
deitch merged 1 commit into from
Jul 27, 2025
Merged

provide mirror support #4148

deitch merged 1 commit into from
Jul 27, 2025

Conversation

@deitch
Copy link
Collaborator

@deitch deitch commented Jul 27, 2025 •
edited
Loading

Fixes #4142

- What I did
Added support for using mirrors to override default registry for specific registries or all registries

You will be able to do:

$ lkt --mirror http://mymirror.local      # to mirror all
$ lkt --mirror ghcr.io=http://mymirror.local      # to mirror just ghcr.io
$ lkt --mirror ghcr.io=http://mymirror.local/ghcr --mirror http://mymirror.local/other      # to mirror ghcr and rest differently

- How I did it
Added the CLI flag, then rewrite the URL

- How to verify it
CI

We probably should add a specific test for this, but I struggled to figure out how. Maybe I will get it

- Description for the changelog

mirror support

@deitch deitch mentioned this pull request Jul 27, 2025
Closed
@deitch deitch force-pushed the mirror-registry branch from 8624bce to 9b8c522 Compare July 27, 2025 09:49
@deitch
Copy link
Collaborator Author

deitch commented Jul 27, 2025

Good, got a test in

@deitch deitch force-pushed the mirror-registry branch 2 times, most recently from d23554c to 83a2c5c Compare July 27, 2025 11:52
@deitch
provide mirror support
eb6b807 
Signed-off-by: Avi Deitcher <[email protected]>
@deitch deitch force-pushed the mirror-registry branch from 83a2c5c to eb6b807 Compare July 27, 2025 12:22
@deitch deitch mentioned this pull request Jul 27, 2025
Merged
@deitch deitch merged commit ef68e7b into linuxkit:master Jul 27, 2025
22 checks passed
@deitch deitch deleted the mirror-registry branch July 27, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature Request: Support overriding default registry during builds

1 participant

@deitch