check lock when reading cache provider index #4147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
We already lock the index before writing to it. However, the write is not atomic; the underlying ggcr library writes it in place. That means that some other thread or process reading it can get a corrupt file if it is mid-write. It would be nice if we could make the writes atomic, but ggcr does not support it.
Instead, we use the same lock everywhere that we read the cache root index. That turns out to be only in three places, so I added a function
cache.Provider.Index()which gets the root index, and that uses the lock.- How I did it
As described above.
- How to verify it
CI
- Description for the changelog
lock when reading cache root index.