swap 'pkg push' for 'pkg build --push', keeping 'pkg push' as depreca… #4141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ted but still working
- What I did
Added
pkg build --pushas a better alternative topkg push, but still keepingpkg pushas functioning (but marked deprecated).It may not seem like much of a difference, but it has two benefits:
First, to users, the flags are more consistent. Flags should always be for one of:
This weird hybrid, where all of the flags were shared for
pkg pushandpkg build, but not any otherpkgsubcommands, was confusing. Now, these arepkg buildcommands.Second, to us, the code supporting it is cleaner and simpler.
- How I did it
Removed the shared function, made it part of
pkgBuild()and changedpkgPush()to just callbuildafter setting--pushflag to true.- How to verify it
CI will check that there are no regressions. I tested each step, including making sure flags get carried over.
- Description for the changelog
pkg build --pushreplacespkg push