-
Notifications
You must be signed in to change notification settings - Fork 1k
docs: Add instructions for OCI export from Docker #4135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
940de8a to
53770a1
Compare
docs/image-cache.md
Outdated
| linuxkit cache import foo.tar | ||
| ``` | ||
|
|
||
| Note that this process only works for the platform/architecture you're currently on - it won’t produce multi-platform images (without extra efforts). For that, you'd need to push to a registry and LinuxKit pull as normal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is not completely correct. You can produce multi-platform images this way using a docker-container builder (actually, this is exactly how linuxkit pkg build does it). You just need to do --platform linux/amd64,linux/arm64,etc.
Maybe just remove this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apologies - it was more "the above, as described". I presume diff arches would need some underlying qemu magic to assist the builds too?
I'll reword slightly to indicate something closer to the truth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
magic to assist the builds too?
Depends on the case. If you use docker desktop, it already is done. You are right, though, there is more to do. Well, sort of. If you use some of buildkit's capabilities for cross-compiling, you might never need emulation.
OK, I am getting way too far into the weeds for this. If you want to discuss cross-builds on Slack, more than happy to. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, for builds, I often use linuxkit pkg build as an opinionated version. It builds multiple platforms, stores in a the cache, etc.
Signed-off-by: Daniel Smith <[email protected]>
53770a1 to
6b067a6
Compare
|
In any case, thank you for this. |
- What I did
Modified
docs/image-cache.mdto note how one can export from a local docker instance into linuxkitcloses #4126
- How I did it
NA
- How to verify it
NA
- Description for the changelog
Add instructions for importing images from local docker instance
- A picture of a cute animal (not mandatory but encouraged)