Centralize safe cache writes #4132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Made concurrent write access to the cache's index safe.
- How I did it
index.jsoninto a single fileIgnored read locks for now, although the utility supports it. Too many places it could be added.
- How to verify it
CI to ensure no regressions, manual testing for lock timing.
- Description for the changelog
Concurrent access to writing
index.jsonin cache