more builder race condition; do restart if could not remove, and only… #4129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… go via container ID Signed-off-by: Avi Deitcher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… go via container ID
- What I did
We already handled the builder container creation in case of a race condition, but what about if it decides to stop and replace it? In that case, 3 different parallel processes all try to remove it, one succeeds, the others fail. Instead, it should do like the start condition, and just loop back.
In addition, to avoid accidentally trouncing one that a different process started, only stop and remove containers via ID.
- How I did it
Changed the code
- How to verify it
I ran it manually, and CI will ensure no regressions.
- Description for the changelog
More builder race condition handling