Skip to content

feat: add riscv64 as supported arch #4124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
deitch merged 1 commit into from
Jun 23, 2025
Merged

feat: add riscv64 as supported arch #4124

deitch merged 1 commit into from
Jun 23, 2025

Conversation

@stskeeps
Copy link
Contributor

@stskeeps stskeeps commented Jun 22, 2025

- What I did
kernel+squashfs flow didn't work for riscv64, which was due to it missing in MArch function

- How I did it
Added riscv64

- How to verify it
Run minimal.yml with -arch riscv64

- Description for the changelog
Fixed bug preventing kernel+squashfs to work for riscv64 target

@stskeeps
feat: add riscv64 as supported arch
9c6cd6f 
this makes kernel+squashfs flow work for risc64

Signed-off-by: Carsten Munk <[email protected]>
@deitch
Copy link
Collaborator

deitch commented Jun 22, 2025

Huh, I really am surprised it is not there. I guess I missed it when adding riscv64.

What happens now when you try? What stage is the failure, and what is the message? Can you paste the command and failure in here?

@stskeeps
Copy link
Contributor Author

stskeeps commented Jun 22, 2025

before (minimal.yml is from examples/) -- linuxkit-darwin-amd64 is latest built by CI in 1.6.0 tag

./linuxkit-darwin-amd64 build --arch riscv64 --format kernel+squashfs minimal.yml
Extract kernel image: docker.io/linuxkit/kernel:6.6.71
Add init containers:
Process init image: docker.io/linuxkit/init:8eea386739975a43af558eec757a7dcb3a3d2e7b
Process init image: docker.io/linuxkit/runc:667e7ea2c426a2460ca21e3da065a57dbb3369c9
Process init image: docker.io/linuxkit/containerd:a988a1a8bcbacc2c0390ca0c08f949e2b4b5915d
Add onboot containers:
  Create OCI config for linuxkit/dhcpcd:157df9ef45a035f1542ec2270e374f18efef98a5
Add service containers:
  Create OCI config for linuxkit/getty:05eca453695984a69617f1f1f0bcdae7f7032967
Create outputs:
  minimal-squashfs.img
Error: error writing outputs: error writing kernel+squashfs output: unknown arch "riscv64"
2025/06/22 18:53:30 error during command execution: error writing outputs: error writing kernel+squashfs output: unknown arch "riscv64"

It's caused by this as far as I can tell:

linuxkit/src/cmd/linuxkit/moby/build/output.go

Line 558 in 89a95f9

march, err := util.MArch(arch)

@deitch deitch merged commit b42e1a8 into linuxkit:master Jun 23, 2025
22 checks passed
@deitch
Copy link
Collaborator

deitch commented Jun 23, 2025

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deitch deitch deitch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stskeeps @deitch