build directly with buildkit#3791
Merged
deitch merged 2 commits intolinuxkit:masterfrom Jul 1, 2022
Merged
Conversation
deitch
force-pushed
the
direct-buildkit
branch
2 times, most recently
from
39a7ce6 to
e068954
Compare
giggsoff
reviewed
Jun 23, 2022
Member
|
there are upwards of 1000 files changed. Is there any chance of breaking this down to changes which matter and changes which are presumably automated updates. |
Collaborator
Author
|
We can split it out into 2 commits, although we had better squash before merging. The only ones that really matter are those in |
Signed-off-by: Avi Deitcher <[email protected]>
Signed-off-by: Avi Deitcher <[email protected]>
Collaborator
Author
|
I split it out into 2 commits. The first updates The second is just a few files with the actual changes. Take another look @rn |
justincormack
approved these changes
Jul 1, 2022
This was referenced Jul 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Avi Deitcher [email protected]
- What I did
For package builds, replaced the usage of
docker buildx buildwith running a buildkit container in a given context and calling the buildkit API directly to that container.Updated the docs in
packages.mdas well.Also provides options to override the builder image to use (default is
moby/buildkit:v0.10.3) as well whether or not to force a stop/rm/restart of the build image. It has logic that will do that if the build image version is incorrect or it is missing permissions.- How to verify it
CI should handle it, as it builds for all platforms.
- Description for the changelog
Direct buildkit usage.
- Additional notes
In principle, this doesn't do too much different than we did with
docker buildx build. It uses contexts to determine where to build, relying on CLI flags or env var or default.What this does buy us is new features. Until now, we were bound by whatever image is in the installed version of buildx, and whatever features are there. This allows us to override the above.
We also had put constraints on the docker version. Now we only need support for contexts, nothing else.
I fully intend to use this as the OCI layout source merges in.
At some point, when buildx and buildkit are very stable, we may choose to remove these changes.