linuxkit bake by w9n · Pull Request #2648 · linuxkit/linuxkit

w9n · 2017-10-28T13:46:19Z

When writing a moby yml I do not care about the container version and hashes (only if I specifically want to stay with a version) and would like to simplify the process of writing them. I also do not want to keep track of all pkg version I use downstream and update them manually when something changes upstream.

The idea is to optionally split the moby config into 1 mutable and n immutable versions. The mutable version describes the desired state which uses image names like linuxkit/containerd:mutable(or the usual hash tags for pinning down on a version), while the immutable configs stay like currently and get created on demand or mutation from a specifc pkg git repo. They can be versioned and stored in the end.

Therefore linuxkit pkg collect --pkgroot /path/to/repo/linuxkit mutable.yml first collects which container in the mutable yml are tagged mutable and then walks recursivly through pkgroot and looks for build.ymlof a package with the same image name. When found it calculates and stores the package hash (Not sure about error case). At this Point we could compare with the last hash of the image and implement build and push on change. At the end a yml with the hashes gets written versioned into a specific dir near the mutable yml and persist as an Artifact for a possible build.

This could also be used for CI that triggers linuxkit pkg collect --push on every pull for every mutable image yml. Would need to save the immutable artifacts somewhere.

The big disadvantage is that you probably dont want moby as dependency in linuxkit which is needed to parse the moby config (On the other side the linuxkit git pkg for the hashes is private). Let me know what you think about it!

(Im just getting used to go, so its a bit messy and uncomplete yet)

GordonTheTurtle · 2017-10-28T13:46:20Z

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "pkg_collect" [email protected]:w9n/linuxkit.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

rn · 2017-10-28T16:54:09Z

I don't understand the explanation for this PR (maybe I'm missing some context).

Could you first describe which problem you try to solve?

w9n · 2017-10-28T22:31:29Z

added some context to the description.

deitch · 2017-10-29T07:03:36Z

When writing a moby yml I do not care about the container version and hashes (only if I specifically want to stay with a version) and would like to simplify the process of writing them. I also do not want to keep track of all pkg version I use downstream and update them manually when something changes upstream

I have a hard time understanding how that would work with immutable images (which is what LinuxKit is all about).

I think this might be easier to understand if you gave sample .yml files for what it would look like if this were in place?

w9n · 2017-10-29T15:02:03Z

i basically thought of a not buildable config

kernel:
  image: linuxkit/kernel:4.9.58
  cmdline: "console=tty0 console=ttyS0 console=ttyAMA0"
init:
  - linuxkit/init:mutable
  - linuxkit/runc:mutable
  - linuxkit/containerd:82be2bbb7cf83bab161ffe2a64624ba1107725ff
  - linuxkit/ca-certificates:mutable
onboot:
  - name: sysctl
    image: linuxkit/sysctl:mutable
  - name: rngd1
    image: linuxkit/rngd:mutable
    command: ["/sbin/rngd", "-1"]
services:
  - name: getty
    image: linuxkit/getty:mutable
    env:
     - INSECURE=true
  - name: rngd
    image: linuxkit/rngd:mutable
  - name: dhcpcd
    image: linuxkit/dhcpcd:mutable
  - name: sshd
    image: linuxkit/sshd:mutable
files:
  - path: root/.ssh/authorized_keys
    source: ~/.ssh/id_rsa.pub
    mode: "0600"
    optional: true
trust:
  org:
    - linuxkit

when used with linuxkit pkg collect --pkgroot /path/to/repo/linuxkit ssh-mutable.yml creates a new file artifacts/ssh-vXYZ.yml with the most current hashes of pkgroot

kernel:
  image: linuxkit/kernel:4.9.58
  cmdline: "console=tty0 console=ttyS0 console=ttyAMA0"
init:
  - linuxkit/init:42a92119e1ca10380e0d33e26c0cbcf85b9b3558
  - linuxkit/runc:817fdc592eac6cb7804fa1721a43a7f6e23fb50f
  - linuxkit/containerd:82be2bbb7cf83bab161ffe2a64624ba1107725ff
  - linuxkit/ca-certificates:af4880e78edc28743f7c5e262678c67c6add4c26
onboot:
  - name: sysctl
    image: linuxkit/sysctl:a9ad57ed738a31ea9380cd73236866c312b35489
  - name: rngd1
    image: linuxkit/rngd:842e5e8ece7934f0cab9fd0027b595ff3471e5b9
    command: ["/sbin/rngd", "-1"]
services:
  - name: getty
    image: linuxkit/getty:626ccc8e1766c40447f29a790d3a7cfff126f2a2
    env:
     - INSECURE=true
  - name: rngd
    image: linuxkit/rngd:842e5e8ece7934f0cab9fd0027b595ff3471e5b9
  - name: dhcpcd
    image: linuxkit/dhcpcd:48831507404049660b960e4055f544917d90378e
  - name: sshd
    image: linuxkit/sshd:f55ec010619e19178d5daecb4e595e84ecbf7d67
files:
  - path: root/.ssh/authorized_keys
    source: ~/.ssh/id_rsa.pub
    mode: "0600"
    optional: true
trust:
  org:
    - linuxkit

I think the main practical reason is to use it in CI where it is necessary to know which pkg has changed to not rebuild everything on a merge. It also gives gives rollback capabilities outside the git history.

But I reevaluated priorities and think its a nice to have but linuxkit is working fine now and i dont think its worth the moby dep. I might create a little external tool for practicing, but low priority.

There is a different problem that a container linuxkit/sshd:f55ec010619e19178d5daecb4e595e84ecbf7d67 is not really immutable because it pulls latest alpine packages on container build time. The current Hash is needed for multi arch but by creating ymls as artifacts it might be possible to use real hashes of a container and make the yml artifacts platform specific. But this gets out of scope for me.

deitch · 2017-10-29T15:09:32Z

So, is this basically a way of saying, "for some packages, I want the latest available hash at build time"?

w9n · 2017-10-29T15:15:12Z

yep, but still create the immutable ymls so its reproducable what has been build and compare what has been changed.

deitch · 2017-10-29T15:16:15Z

So rather than the usual moby .yml, it kind of is a moby "template" .yml, that gets parsed to generate the real .yml with immutable hashes? Still immutable, but somewhat easier to maintain?

w9n · 2017-10-29T15:19:12Z

exactly. It would enable other possibilities as well as described above but there might be other ideas for CI and real hashes.

deitch · 2017-10-29T15:20:35Z

OK, I get it now; want to think it over somewhat. @rn had commented earlier; let's see his thoughts.

I am going to rename the issue.

rn · 2017-10-29T15:28:39Z

This would be better done in the moby tool as it handles the build YAML files. There are two related proposals:

deitch · 2017-10-29T15:35:23Z

Ah yes, the .mobytags and overrides proposals.

@w9n does that address the question?

w9n · 2017-10-29T16:14:46Z

yes, it pretty much goes is in the right direction. I will read and think about the related Issues and PRs in the next days.

ijc · 2017-11-01T10:50:48Z

I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this one yet, but one quick though I had was that what is called foo:mutable here would be called foo:latest in many other contexts.

w9n · 2017-11-02T20:44:36Z

i didnt choose foo:latest because it can conflict with other contexts. But can maybe be prevented if carefully designed. I created a proper proposal.

w9n · 2017-12-17T22:11:39Z

Since moby became a dependency this works now depending on moby/tool#194 linuxkit pkg collect --pkgroot ~/go/src/github.com/linuxkit/linuxkit/pkg test.yml

test,yml

kernel:
  image: linuxkit/kernel:4.9.58
  cmdline: "console=tty0 console=ttyS0 console=ttyAMA0"
init:
  - linuxkit/init:<latest>
  - linuxkit/runc:<latest>
  - linuxkit/containerd:82be2bbb7cf83bab161ffe2a64624ba1107725ff
  - linuxkit/ca-certificates:<latest>
onboot:
  - name: sysctl
    image: linuxkit/sysctl:<latest>
  - name: rngd1
    image: linuxkit/rngd:<latest>
    command: ["/sbin/rngd", "-1"]
services:
  - name: getty
    image: linuxkit/getty:<latest>
    env:
     - INSECURE=true
  - name: rngd
    image: linuxkit/rngd:<latest>
  - name: dhcpcd
    image: linuxkit/dhcpcd:<latest>
  - name: sshd
    image: linuxkit/sshd:<latest>
files:
  - path: root/.ssh/authorized_keys
    source: ~/.ssh/id_rsa.pub
    mode: "0600"
    optional: true
trust:
  org:
    - linuxkit

result hash of the yml files bytes (5f39869eef39b525e90661e2327ed645c1a9df8a.yml)

kernel:
  image: linuxkit/kernel:4.9.58
  cmdline: console=tty0 console=ttyS0 console=ttyAMA0
init:
- linuxkit/init:9250948d0de494df8a811edb3242b4584057cfe4
- linuxkit/runc:abc3f292653e64a2fd488e9675ace19a55ec7023
- linuxkit/containerd:82be2bbb7cf83bab161ffe2a64624ba1107725ff
- linuxkit/ca-certificates:de21b84d9b055ad9dcecc57965b654a7a24ef8e0
onboot:
- name: sysctl
  image: linuxkit/sysctl:ce3bde5118a41092f1b7048c85d14fb35237ed45
- name: rngd1
  image: linuxkit/rngd:94e01a4b16fadb053455cdc2269c4eb0b39199cd
  command:
  - /sbin/rngd
  - "-1"
onshutdown: []
services:
- name: getty
  image: linuxkit/getty:22e27189b6b354e1d5d38fc0536a5af3f2adb79f
  env:
  - INSECURE=true
- name: rngd
  image: linuxkit/rngd:94e01a4b16fadb053455cdc2269c4eb0b39199cd
- name: dhcpcd
  image: linuxkit/dhcpcd:0d59a6cc03412289ef4313f2491ec666c1715cc9
- name: sshd
  image: linuxkit/sshd:ac5e8364e2e9aa8717a3295c51eb60b8c57373d5
trust:
  org:
  - linuxkit
files:
- path: root/.ssh/authorized_keys
  directory: false
  source: ~/.ssh/id_rsa.pub
  optional: true
  mode: "0600"

_
I would like to have a file like ~/.linuxkit.conf where i can specify multiple pkg roots.
It could also easily be upgraded to support version tags in that file (as proposed in moby/tool#101 ) or in the build.yml in the pkg directory.

justincormack · 2018-01-10T11:46:08Z

I don't understand what the output of linuxkit bake example/linuxkit_template.yml is. Does it output another file, modify the existing file or do a build?

ijc · 2018-01-10T11:57:52Z

It's a new file which you can pass to linuxkit build (after archiving it for reproducibility purposes etc).

justincormack · 2018-01-10T12:00:24Z

Does it output to stdout or what? This needs to be documented properly.

w9n · 2018-01-10T12:01:57Z

Okay, so I could live with this somewhere:

tags:
    - name: v1.0
        init: some_hash
        dhcp: some_hash
    - name: v2.0
        init: some_other_hash
        dhcp: another_hash

Its basically the same information as if tags -> hashes would be in build.yml(what i proposed) just at a different location (undecided if this is the better position or just a cache). The advantage is that you can e.g. hotfix v1.0 or what else for one pkg without influencing everything else.

@justincormack yes its writing to stdout and logging to stderr but i could also give it a -o multiflag if wished.

rn · 2018-01-10T12:12:46Z

@w9n please read my comment #2648 (comment). Could we initially focus on the templating stuff itself (ie replacing <latest> with the hash of the package). It seem separate from the version tags and both @ijc and myself are not sure if we should handle the version tags that way, ie by extending build.yml

w9n · 2018-01-10T12:26:01Z

Do you have an example for a baked YAML file. It would be useful if it would contain comments at the top stating that the file was generated, and ideally also the HEAD of the package repositories used to generate it. I would check in the generated file and this info would be useful. The first part (the log) is written to stderr, so that stdout can be piped anywhere.

added ###----------- AUTO-GENERATED--------### to the output. Here is the output of linuxkit bake linuxkit_template.yml. I dont think i could easily print a comment above an image field in a moby structure when marshalling the yml.

EDIT: I would need to make a git method public (or hack together something) to get the hash of a pkgroot for a comment in the bake or cli context.

template: linuxkit/ca-certificates:<latest>
    path: /home/user/go/src/github.com/linuxkit/linuxkit/pkg/ca-certificates
  hashed: linuxkit/ca-certificates:de21b84d9b055ad9dcecc57965b654a7a24ef8e0
--------------------------
template: linuxkit/containerd:<latest>
    path: /home/user/go/src/github.com/linuxkit/linuxkit/pkg/containerd
  hashed: linuxkit/containerd:e58a382c33bb509ba3e0e8170dfaa5a100504c5b
--------------------------
template: linuxkit/dhcpcd:<latest>
    path: /home/user/go/src/github.com/linuxkit/linuxkit/pkg/dhcpcd
  hashed: linuxkit/dhcpcd:0d59a6cc03412289ef4313f2491ec666c1715cc9
--------------------------
template: linuxkit/getty:<latest>
    path: /home/user/go/src/github.com/linuxkit/linuxkit/pkg/getty
  hashed: linuxkit/getty:22e27189b6b354e1d5d38fc0536a5af3f2adb79f
--------------------------
template: linuxkit/init:<latest>
    path: /home/user/go/src/github.com/linuxkit/linuxkit/pkg/init
  hashed: linuxkit/init:5a577d070817b4f17821657823082651baafd4ed
--------------------------
template: linuxkit/rngd:<latest>
    path: /home/user/go/src/github.com/linuxkit/linuxkit/pkg/rngd
  hashed: linuxkit/rngd:94e01a4b16fadb053455cdc2269c4eb0b39199cd
--------------------------
template: linuxkit/runc:<latest>
    path: /home/user/go/src/github.com/linuxkit/linuxkit/pkg/runc
  hashed: linuxkit/runc:abc3f292653e64a2fd488e9675ace19a55ec7023
--------------------------
template: linuxkit/sysctl:<latest>
    path: /home/user/go/src/github.com/linuxkit/linuxkit/pkg/sysctl
  hashed: linuxkit/sysctl:4c1ef93bb5eb1a877318db4b2daa6768ed002e21
--------------------------
###----------- AUTO-GENERATED--------###
kernel:
  image: linuxkit/kernel:4.9.75
  cmdline: console=tty0 console=ttyS0 console=ttyAMA0
init:
- linuxkit/init:5a577d070817b4f17821657823082651baafd4ed
- linuxkit/runc:abc3f292653e64a2fd488e9675ace19a55ec7023
- linuxkit/containerd:e58a382c33bb509ba3e0e8170dfaa5a100504c5b
- linuxkit/ca-certificates:de21b84d9b055ad9dcecc57965b654a7a24ef8e0
onboot:
- name: sysctl
  image: linuxkit/sysctl:4c1ef93bb5eb1a877318db4b2daa6768ed002e21
- name: dhcpcd
  image: linuxkit/dhcpcd:0d59a6cc03412289ef4313f2491ec666c1715cc9
  command:
  - /sbin/dhcpcd
  - --nobackground
  - -f
  - /dhcpcd.conf
  - "-1"
onshutdown:
- name: shutdown
  image: busybox:latest
  command:
  - /bin/echo
  - so long and thanks for all the fish
services:
- name: getty
  image: linuxkit/getty:22e27189b6b354e1d5d38fc0536a5af3f2adb79f
  env:
  - INSECURE=true
- name: rngd
  image: linuxkit/rngd:94e01a4b16fadb053455cdc2269c4eb0b39199cd
- name: nginx
  image: nginx:alpine
  capabilities:
  - CAP_NET_BIND_SERVICE
  - CAP_CHOWN
  - CAP_SETUID
  - CAP_SETGID
  - CAP_DAC_OVERRIDE
  binds:
  - /etc/resolv.conf:/etc/resolv.conf
trust:
  org:
  - linuxkit
  - library
files:
- path: etc/containerd/config.toml
  directory: false
  contents: |
    state = "/run/containerd"
    root = "/var/lib/containerd"
    snapshotter = "io.containerd.snapshotter.v1.overlayfs"
    differ = "io.containerd.differ.v1.base-diff"
    subreaper = false

    [grpc]
    address = "/run/containerd/containerd.sock"
    uid = 0
    gid = 0

    [debug]
    address = "/run/containerd/debug.sock"
    level = "info"

    [metrics]
    address = ":13337"
  optional: false
- path: etc/linuxkit-config
  directory: false
  metadata: yaml
  optional: false

w9n · 2018-01-10T12:35:02Z

i dont really trust the test time, something must be wrong...

[+ 24m 58s] [PASS    ] linuxkit.build.examples.bake 0.04s

w9n · 2018-01-10T16:01:37Z

@ijc

linuxkit bake -D foo=abcdef foo.yml

This can actually be done with envsubst and also be piped from bake as it is.

EDIT:
I can see now how linuxkit pkg push --release v1.1 and git tags can work together but im still not completly convinced that its a good a idea to make a pkg version explicitly dependend on a repo that contains a pkg root and not the other way round(you have to checkout the whole repo to rebuild one old pkg e.g.).

Additional tags in build.yml could still be helpful (future, not in this pr).

There is https://github.com/a8m/envsubst I could implement this from a file, global conf, cli and/or env after merging the moby confs and before substituting the latest tag, for 1:1 substitution on the whole config file. This could allow something like lkt_version=<latest> linuxkit bake some.yml more.yml on

services:
- name: getty
  image: ${lkt_repo-linuxkit}/getty:${lkt_version-v1.0}

It had a few "bugs" for nested stuff i tried but should work for simple envsubst

otherwise there could be go templates

init:
{{if .Dev}}
  {{call .Image "linuxkit/getty"}} 
{{end}}
  {{call .Image "linuxkit/dhcpcd"}} 
  {{call .Image "linuxkit/runc"}} 
#which could either do the `latest` logic or set a tag based on some variable

....

but it gets pretty ugly from my experience

or

services:
- name: getty
  image: linuxkit/getty:<lkt_version>
- name: dhcpcd
  image: linuxkit/dhcpcd:<lkt_version>
- name: sshd
  image: linuxkit/sshd:<latest>

w9n · 2018-01-11T12:38:35Z

updated the last comment, otherwise i guess i should revert setting global config in its own namespace and pass the repos as strings into Bake for better encapsulation. Let me know if you would like one of the proposed solutions in this PR. I could implement it tonight or leave it.

Signed-off-by: Robin Winkelewski <[email protected]>

w9n · 2018-01-12T07:37:17Z

Sorry for all these changes

dropped putting GlobalConfig in its own namespace
squashed the git commit stuff
moved logging from Template to bake cli and writing it as comment into the result
add Time.Now() to log comment
gave Template a more defined surface based on a Template, Result and Substitution structures. Template.Bake() (Result,error) is the only public function.

here is a result yml:

Details


###-------------------------------AUTO-GENERATED-------------------------------###
#     time: 2018-01-12 08:28:29.070212358 +0100 CET m=+0.383653088
#-----------------------------------------------------------------------------------
# template: linuxkit/ca-certificates:<latest>
#   source: /home/user/go/src/github.com/linuxkit/linuxkit/pkg/ca-certificates
#   result: linuxkit/ca-certificates:de21b84d9b055ad9dcecc57965b654a7a24ef8e0
#-----------------------------------------------------------------------------------
# template: linuxkit/containerd:<latest>
#   source: /home/user/go/src/github.com/linuxkit/linuxkit/pkg/containerd
#   result: linuxkit/containerd:e58a382c33bb509ba3e0e8170dfaa5a100504c5b
#-----------------------------------------------------------------------------------
# template: linuxkit/dhcpcd:<latest>
#   source: /home/user/go/src/github.com/linuxkit/linuxkit/pkg/dhcpcd
#   result: linuxkit/dhcpcd:0d59a6cc03412289ef4313f2491ec666c1715cc9
#-----------------------------------------------------------------------------------
# template: linuxkit/getty:<latest>
#   source: /home/user/go/src/github.com/linuxkit/linuxkit/pkg/getty
#   result: linuxkit/getty:22e27189b6b354e1d5d38fc0536a5af3f2adb79f
#-----------------------------------------------------------------------------------
# template: linuxkit/init:<latest>
#   source: /home/user/go/src/github.com/linuxkit/linuxkit/pkg/init
#   result: linuxkit/init:5a577d070817b4f17821657823082651baafd4ed
#-----------------------------------------------------------------------------------
# template: linuxkit/rngd:<latest>
#   source: /home/user/go/src/github.com/linuxkit/linuxkit/pkg/rngd
#   result: linuxkit/rngd:94e01a4b16fadb053455cdc2269c4eb0b39199cd
#-----------------------------------------------------------------------------------
# template: linuxkit/runc:<latest>
#   source: /home/user/go/src/github.com/linuxkit/linuxkit/pkg/runc
#   result: linuxkit/runc:abc3f292653e64a2fd488e9675ace19a55ec7023
#-----------------------------------------------------------------------------------
# template: linuxkit/sysctl:<latest>
#   source: /home/user/go/src/github.com/linuxkit/linuxkit/pkg/sysctl
#   result: linuxkit/sysctl:4c1ef93bb5eb1a877318db4b2daa6768ed002e21
#-----------------------------------------------------------------------------------
kernel:
  image: linuxkit/kernel:4.9.75
  cmdline: console=tty0 console=ttyS0 console=ttyAMA0
init:
- linuxkit/init:5a577d070817b4f17821657823082651baafd4ed
- linuxkit/runc:abc3f292653e64a2fd488e9675ace19a55ec7023
- linuxkit/containerd:e58a382c33bb509ba3e0e8170dfaa5a100504c5b
- linuxkit/ca-certificates:de21b84d9b055ad9dcecc57965b654a7a24ef8e0
onboot:
- name: sysctl
  image: linuxkit/sysctl:4c1ef93bb5eb1a877318db4b2daa6768ed002e21
- name: dhcpcd
  image: linuxkit/dhcpcd:0d59a6cc03412289ef4313f2491ec666c1715cc9
  command:
  - /sbin/dhcpcd
  - --nobackground
  - -f
  - /dhcpcd.conf
  - "-1"
onshutdown:
- name: shutdown
  image: busybox:latest
  command:
  - /bin/echo
  - so long and thanks for all the fish
services:
- name: getty
  image: linuxkit/getty:22e27189b6b354e1d5d38fc0536a5af3f2adb79f
  env:
  - INSECURE=true
- name: rngd
  image: linuxkit/rngd:94e01a4b16fadb053455cdc2269c4eb0b39199cd
- name: nginx
  image: nginx:alpine
  capabilities:
  - CAP_NET_BIND_SERVICE
  - CAP_CHOWN
  - CAP_SETUID
  - CAP_SETGID
  - CAP_DAC_OVERRIDE
  binds:
  - /etc/resolv.conf:/etc/resolv.conf
trust:
  org:
  - linuxkit
  - library
files:
- path: etc/containerd/config.toml
  directory: false
  contents: |
    state = "/run/containerd"
    root = "/var/lib/containerd"
    snapshotter = "io.containerd.snapshotter.v1.overlayfs"
    differ = "io.containerd.differ.v1.base-diff"
    subreaper = false

    [grpc]
    address = "/run/containerd/containerd.sock"
    uid = 0
    gid = 0

    [debug]
    address = "/run/containerd/debug.sock"
    level = "info"

    [metrics]
    address = ":13337"
  optional: false
- path: etc/linuxkit-config
  directory: false
  metadata: yaml
  optional: false

It should be easier to review and extend now. I didnt implement 1:1 substitution because its not needed yet and pipes can be used.

EDIT: needed to add a deep copy function of Moby to make the result not change the initial template.

Signed-off-by: Robin Winkelewski <[email protected]>

w9n · 2018-01-13T10:54:50Z

[+ 24m 27s] [PASS    ] linuxkit.build.examples.bake 32.57s

fixed test. Should cover everything but global config parsing.

Signed-off-by: Robin Winkelewski <[email protected]>

rn · 2019-02-06T00:28:28Z

I think we probably still want to have some improvement in this area, but this PR is pretty outdated so closing it for now

GordonTheTurtle added dco/no status/0-triage labels Oct 28, 2017

deitch changed the title ~~WIP: linuxkit pkg collect~~ WIP: linuxkit pkg template yml to generate immutable yml for reuse Oct 29, 2017

w9n closed this Oct 29, 2017

w9n mentioned this pull request Nov 2, 2017

Proposal: package managment #2674

Closed

w9n reopened this Dec 17, 2017

GordonTheTurtle added the dco/no label Dec 17, 2017

w9n force-pushed the pkg_collect branch from a07bb35 to 9ba959b Compare December 17, 2017 21:13

GordonTheTurtle removed the dco/no label Dec 17, 2017

w9n force-pushed the pkg_collect branch 3 times, most recently from 3ebd47f to 557bb5c Compare December 17, 2017 21:47

w9n mentioned this pull request Dec 17, 2017

add omitempty for yml config moby/tool#194

Merged

w9n force-pushed the pkg_collect branch from 557bb5c to 083d497 Compare December 26, 2017 13:43

w9n force-pushed the pkg_collect branch from 3f2c97c to 406272a Compare January 10, 2018 12:06

w9n force-pushed the pkg_collect branch from 406272a to b49947d Compare January 10, 2018 12:31

w9n force-pushed the pkg_collect branch from b49947d to 4b63d4e Compare January 10, 2018 12:40

w9n added 2 commits January 12, 2018 08:02

pkglib: add New(path string) constructor and refactor

f438673

Signed-off-by: Robin Winkelewski <[email protected]>

pkglib: expose Image

bdd4676

Signed-off-by: Robin Winkelewski <[email protected]>

w9n force-pushed the pkg_collect branch 2 times, most recently from 65a8b51 to 48fdb00 Compare January 12, 2018 07:22

w9n force-pushed the pkg_collect branch 2 times, most recently from 8560131 to bd4e342 Compare January 13, 2018 08:33

template: introduce moby-repo templating engine

c6c6c3d

Signed-off-by: Robin Winkelewski <[email protected]>

w9n force-pushed the pkg_collect branch from bd4e342 to 8ef40ab Compare January 13, 2018 08:42

GordonTheTurtle added the dco/no label Jan 13, 2018

w9n force-pushed the pkg_collect branch from 0ab2ace to ddd27ea Compare January 13, 2018 08:57

GordonTheTurtle removed the dco/no label Jan 13, 2018

w9n added 2 commits January 13, 2018 10:31

cli: introduce linuxkit bake

8326ab2

Signed-off-by: Robin Winkelewski <[email protected]>

docs: add bake docs

2911de5

Signed-off-by: Robin Winkelewski <[email protected]>

w9n force-pushed the pkg_collect branch from ddd27ea to 6172b06 Compare January 13, 2018 09:31

tests: add linuxkit bake case

bfaa9e7

Signed-off-by: Robin Winkelewski <[email protected]>

Conversation

w9n commented Oct 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GordonTheTurtle commented Oct 28, 2017

Uh oh!

rn commented Oct 28, 2017

Uh oh!

w9n commented Oct 28, 2017

Uh oh!

deitch commented Oct 29, 2017

Uh oh!

w9n commented Oct 29, 2017

Uh oh!

deitch commented Oct 29, 2017

Uh oh!

w9n commented Oct 29, 2017

Uh oh!

deitch commented Oct 29, 2017

Uh oh!

w9n commented Oct 29, 2017

Uh oh!

deitch commented Oct 29, 2017

Uh oh!

rn commented Oct 29, 2017

Uh oh!

deitch commented Oct 29, 2017

Uh oh!

w9n commented Oct 29, 2017

Uh oh!

ijc commented Nov 1, 2017

Uh oh!

w9n commented Nov 2, 2017

Uh oh!

w9n commented Dec 17, 2017

Uh oh!

justincormack commented Jan 10, 2018

Uh oh!

ijc commented Jan 10, 2018

Uh oh!

justincormack commented Jan 10, 2018

Uh oh!

w9n commented Jan 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rn commented Jan 10, 2018

Uh oh!

w9n commented Jan 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

w9n commented Jan 10, 2018

Uh oh!

w9n commented Jan 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

w9n commented Jan 11, 2018

Uh oh!

w9n commented Jan 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

w9n commented Jan 13, 2018

Uh oh!

rn commented Feb 6, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

w9n commented Oct 28, 2017 •

edited

Loading

w9n commented Jan 10, 2018 •

edited

Loading

w9n commented Jan 10, 2018 •

edited

Loading

w9n commented Jan 10, 2018 •

edited

Loading

w9n commented Jan 12, 2018 •

edited

Loading