genhtml: Support relative source filenames in SF keys#1
Closed
pwithnall wants to merge 1 commit intolinux-test-project:masterfrom
Closed
genhtml: Support relative source filenames in SF keys#1pwithnall wants to merge 1 commit intolinux-test-project:masterfrom
pwithnall wants to merge 1 commit intolinux-test-project:masterfrom
Conversation
Some tools which generate .info files generate relative filenames for the ‘SF’ keys. For example, nodeunit’s lcov output does. When genhtml is run with --output-directory, it calls chdir() which breaks relative lookup of the source files. Fix that by resolving all source filenames to absolute paths when loading an info file, resolving any relative ones using the info file’s path as a base. Signed-off-by: Philip Withnall <[email protected]>
pwithnall
force-pushed
the
relative-sf
branch
from
db20d36 to
4a3f036
Compare
Author
|
Updated to add info() call, resolve relative to CWD, and add a signed-off-by line. |
Author
|
This was committed as 2a634f6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tools which generate .info files generate relative filenames for
the ‘SF’ keys. For example, nodeunit’s lcov output does. When genhtml is
run with --output-directory, it calls chdir() which breaks relative
lookup of the source files. Fix that by resolving all source filenames
to absolute paths when loading an info file, resolving any relative ones
using the info file’s path as a base.