pam_access: only consider FQDN for host matches#835
Open
rpigott wants to merge 1 commit intolinux-pam:masterfrom
Open
pam_access: only consider FQDN for host matches#835rpigott wants to merge 1 commit intolinux-pam:masterfrom
rpigott wants to merge 1 commit intolinux-pam:masterfrom
Conversation
Since 23393be, every token in the origin field of the access.conf configuration may be considered a hostname. Some exceptions were made for keywords ALL and LOCAL, but that leaves open the possiblity of unintenionally matching any service or tty name as a hostname in the case of remote logins. There is currently no way to distinguish an origin that should only match a PAM_SERVICE or PAM_TTY enabling hosts named like ttyN or crond to bypass many pam_access configurations. Require all hostname origins to be specified as a FQDN, ending with a ".". This way tty and service names will not be confused for unqualified hostnames. Fixes: 23393be (pam_access: handle hostnames in access.conf, 2022-02-24)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 23393be, every token in the origin field of the access.conf configuration may be considered a hostname. Some exceptions were made for keywords ALL and LOCAL, but that leaves open the possiblity of unintenionally matching any service or tty name as a hostname in the case of remote logins. There is currently no way to distinguish an origin that should only match a PAM_SERVICE or PAM_TTY enabling hosts named like ttyN or crond to bypass many pam_access configurations.
Require all hostname origins to be specified as a FQDN, ending with a ".". This way tty and service names will not be confused for unqualified hostnames.
Fixes: 23393be (pam_access: handle hostnames in access.conf, 2022-02-24)
Fixes: #834