pam_access: clean up the remote host matching code#345
Merged
t8m merged 1 commit intolinux-pam:masterfrom Apr 12, 2021
Merged
Conversation
jo-he
reviewed
Apr 6, 2021
jo-he
reviewed
Apr 6, 2021
Member
Author
|
I did one more change - moved the domain match to remote match as it makes no sense to do it against TTY or SERVICE. |
Member
Author
|
@ldv-alt Please review |
|
closes #343 |
ldv-alt
requested changes
Apr 12, 2021
* modules/pam_access/pam_access.c (from_match): Split out remote_match() function and avoid calling it when matching against LOCAL keyword. There is also no point in doing domain match against TTY or SERVICE.
ldv-alt
approved these changes
Apr 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
function and avoid calling it when matching against LOCAL keyword.