Skip to content

feat 菜单栏高亮#87

Merged
chenyme merged 6 commits intolinux-do:masterfrom
lorsque-sir:master
Jul 9, 2025
Merged

feat 菜单栏高亮#87
chenyme merged 6 commits intolinux-do:masterfrom
lorsque-sir:master

Conversation

@lorsque-sir
Copy link
Copy Markdown
Contributor

@lorsque-sir lorsque-sir commented Jul 8, 2025

例行检查

  • 我已阅读并理解 贡献者公约
  • 我已阅读并同意 贡献者许可协议 (CLA),确认我的贡献将根据项目的 MIT 许可证进行许可,
  • 我知晓如果此 PR 并不做出实质性更改,或可被认为是为了PR被合并而提交PR的,则可能不会被合并,

关联信息

变更内容

菜单选中时高亮和样式优化

变更原因
之前的菜单栏选中无高亮,不容易区分

@lorsque-sir lorsque-sir changed the title 菜单栏高亮 fit 菜单栏高亮 Jul 8, 2025
@lorsque-sir lorsque-sir changed the title fit 菜单栏高亮 feat 菜单栏高亮 Jul 8, 2025
@chenyme
Copy link
Copy Markdown
Collaborator

chenyme commented Jul 9, 2025

佬,能否换个配色~ 看上去有点怪怪滴哈哈哈

同时注意一下 Eslint 规范哈~

image

@lorsque-sir
Copy link
Copy Markdown
Contributor Author

Eslint 我本地使用正常,你们用的什么插件,配色我修改下

Copy link
Copy Markdown
Collaborator

@TethysPlex TethysPlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议 Linux Do CDK 标题不需要高亮,然后背景色个人建议 bg-gray-50 dark:bg-gray-800
边框和左侧那个蓝条我个人感觉不必要()

标题在 /explore 下会高亮,不建议()
image

@lorsque-sir
Copy link
Copy Markdown
Contributor Author

image image

我之前这么做觉得颜色对比度不够高

@lorsque-sir lorsque-sir requested a review from TethysPlex July 9, 2025 06:48
@lorsque-sir
Copy link
Copy Markdown
Contributor Author

我明白了,以后我再提交前运行下 pnpm build,应该会暴露 eslint 问题

@chenyme chenyme self-requested a review July 9, 2025 08:30
@chenyme chenyme merged commit a53b074 into linux-do:master Jul 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants