fix: update pull request template for clarity and formatting#44
Merged
chenyme merged 2 commits intolinux-do:masterfrom Jul 3, 2025
OrenZhang:feat_pr_check
Merged
fix: update pull request template for clarity and formatting#44chenyme merged 2 commits intolinux-do:masterfrom OrenZhang:feat_pr_check
chenyme merged 2 commits intolinux-do:masterfrom
OrenZhang:feat_pr_check
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds a GitHub Actions workflow to ensure all pull request template checklist items are checked before merging.
- Introduce new
pr-template-check.ymlworkflow triggered on PR opened/edited/synchronize - Uses
actions/github-script@v7to scan the PR body for checklist items - Fails the workflow if any checklist items remain unchecked
Comments suppressed due to low confidence (2)
.github/workflows/pr-template-check.yml:21
- The workflow passes if no checklist items are present. Consider failing the job when
matches.length === 0to enforce inclusion of the checklist section in the PR body.
const matches = prBody.match(checklistRegex) || [];
.github/workflows/pr-template-check.yml:20
- [nitpick] The current regex only matches checklist items at the start of the line. To handle indented lists or nested sections, you could allow optional leading whitespace:
/^\s*- \[( |x|X)\] .+$/gm.
const checklistRegex = /^- \[( |x|X)\] .+$/gm;
chenyme
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
例行检查
变更内容
增加对于 PR 内容的检查 Workflow
变更原因