Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where user scores exceeding the int8 range caused errors by centralizing score updates and adding clamping logic.
- Replace inline GORM update in
updateUserScorewith a call toUser.SetScore - Change
SetScoresignature fromint8tointand clamp values toMinUserScore/MaxUserScore
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/apps/oauth/tasks.go | Swapped raw DB update for user.SetScore call in updateUserScore |
| internal/apps/oauth/models.go | Updated SetScore to take an int, enforce bounds, and persist to DB |
Comments suppressed due to low confidence (3)
internal/apps/oauth/models.go:61
- [nitpick] Add a doc comment above
SetScoreto describe its parameters, side effects, and clamping behavior for better clarity.
func (u *User) SetScore(tx *gorm.DB, newScore int) error {
internal/apps/oauth/models.go:69
- Add unit tests for
SetScorecovering cases wherenewScoreis belowMinUserScoreand aboveMaxUserScoreto verify that values are correctly clamped and persisted.
return tx.Model(u).Update("score", u.Score).Error
internal/apps/oauth/models.go:62
- There may be a type mismatch between
newScore(int) andMinUserScore/MaxUserScore; consider aligning their types or explicitly casting the constants to avoid potential compilation issues.
if newScore < MinUserScore {
OrenZhang
approved these changes
Jul 2, 2025
TethysPlex
approved these changes
Jul 2, 2025
tabloving
pushed a commit
to tabloving/cdk
that referenced
this pull request
Jul 3, 2025
feat(trace): trace injection for gin mysql redis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.