Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: linsomniac/python-memcached
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.61
Choose a base ref
...
head repository: linsomniac/python-memcached
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.62
Choose a head ref
  • 7 commits
  • 7 files changed
  • 3 contributors

Commits on Dec 30, 2023

  1. Configuration menu
    Copy the full SHA
    718233c View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2023

  1. Merge pull request #189 from ngnpope/cleanup-travis-ci

    Removed obsolete configuration for Travis CI.  (Nick Pope #189 )
    linsomniac authored Dec 31, 2023
    Configuration menu
    Copy the full SHA
    b515221 View commit details
    Browse the repository at this point in the history
  2. Adding changelog entry

    linsomniac committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    deac889 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Fixed return value from delete command.

    The `delete()` command currently returns `1` if the response from the
    server is either `'DELETED'` or `'NOT_FOUND'`. This differs from other
    implementations, e.g. `pymemcache` and `pylibmc`, and doesn't seem to
    make sense given that these are the only two documented return types
    from the protocol for the delete command.
    
    It seems that `delete()` was changed to explicitly consider both
    responses as successful way back in 2010, but that change only seemed to
    double down on the behavior that was being reported in the issue.
    See https://bugs.launchpad.net/python-memcached/+bug/471727. The concern
    was avoiding breaking backward compatibility.
    
    It was possible to work around this by calling `_deletetouch()` and
    passing in the `expected` responses, but that was broken by the change
    to remove `time` in ab668ed.
    
    Making the change to interpret `'NOT_FOUND'` as `0` doesn't cause any
    test failures, is consistent with the docstring which states that that
    the command returns non-zero on success, and also brings consistency
    with other implementations.
    
    Fixes #170.
    ngnpope committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    c9a1626 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Merge pull request #190 from ngnpope/fix-delete-return

    delete() return value now is 1 for "DELETED" and 0 for "NOT_FOUND" or server error.
    linsomniac authored Jan 3, 2024
    Configuration menu
    Copy the full SHA
    880fe69 View commit details
    Browse the repository at this point in the history
  2. Updating ChangeLog

    linsomniac committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    b5d59ca View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2024

  1. Configuration menu
    Copy the full SHA
    5c5cb1b View commit details
    Browse the repository at this point in the history
Loading