-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(authenticate): Provide credentials for HTTP authentication #125
Conversation
a65305e
to
a6ceb73
Compare
BTW: fix a CI bug(puppeteer/puppeteer#13196)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a section in the README to document this workaround for new ubuntu versions? If so PR LGTM. Thank you.
fix(ci): disable AppArmor restrictions on Ubuntu refer puppeteer/puppeteer#13196
I wanna write a unit test for Is it possible to get json response from page?
|
Oops, merged it on accident. I'm going to revert the change. Could you open a new PR? |
I think your approach is probably the right way to go about it? I would test it and find out. Not entirely sure how to do that. |
Same as https://pptr.dev/api/puppeteer.page.authenticate