Conversation
sujaypatil96
left a comment
sujaypatil96
left a comment
There was a problem hiding this comment.
@rosdyana: Since versioneer is a PyPI package, would you mind removing versioneer.py from this PR, and adding it to the list of dependencies in the Pipfile?
|
@sujaypatil96 I believe versioneer.py is generated file from the Versioneer. You may check on their repository (https://github.com/python-versioneer/python-versioneer/blob/master/INSTALL.md). And probably you can check on the other project like Pandas (https://github.com/pandas-dev/pandas/blob/master/versioneer.py). Let me know if you need any. |
|
Thank you for clarifying that @rosdyana. I had a couple of other comments though. |
sujaypatil96
left a comment
sujaypatil96
left a comment
There was a problem hiding this comment.
Would you be able to resolve these two comments @rosdyana? I think we should be good to merge it right after.
|
@sujaypatil96 Sure, I just pushed a new commit to resolve that issue, thanks! |
sujaypatil96
left a comment
sujaypatil96
left a comment
There was a problem hiding this comment.
Thank you @rosdyana. I think this PR is good to be merged.🚀
|
Hi @rosdyana - we just migrated LinkML to use the poetry virtual environment and package management framework. I think I need to close this PR as it changes files that were removed during this migration. With that change, have we addressed your versioning concerns? If not, please do submit another PR and we can address it ASAP. |
Convert test_loaders.py to pytest format
3 participants
Solve issue #378