abstract common add_mapping code into parent generator#283
Merged
Conversation
…on parent Fixes #278 Also: Fixes #163 Fixes biolink/biolink-model#667
cmungall
commented
Jul 21, 2021
| SchemaLoader(METAMODEL_YAML_URI, base_dir=META_BASE_URI, importmap=kwargs.get('importmap', None), | ||
| mergeimports=self.merge_imports) | ||
| self.metamodel.resolve() | ||
| self.emit_prefixes: Set[str] = set() |
Member
Author
There was a problem hiding this comment.
@hsolbrig doesn't seem satisfactory having to do this in every init method - move up to parent and set as a default?
Contributor
|
It appears that lines 572 through 575 in generator.py are causing the above error. Why were these 4 lines introduced: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #278
Also:
Fixes #163
Fixes biolink/biolink-model#667