Add dynamic versioning and --version command line option#1048
Merged
cmungall merged 3 commits intolinkml:mainfrom Oct 27, 2022
Merged
Add dynamic versioning and --version command line option#1048cmungall merged 3 commits intolinkml:mainfrom
cmungall merged 3 commits intolinkml:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1048 +/- ##
==========================================
- Coverage 78.06% 78.06% -0.01%
==========================================
Files 73 74 +1
Lines 8390 8398 +8
Branches 2063 2063
==========================================
+ Hits 6550 6556 +6
- Misses 1446 1448 +2
Partials 394 394
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
hsolbrig
approved these changes
Oct 27, 2022
Contributor
hsolbrig
left a comment
hsolbrig
left a comment
There was a problem hiding this comment.
Looks great! Thanks.
Appreciate the insights on how poetry can get the actual version from github. We should really consider doing that for model versions as well ...
Member
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses partly #1034. Click by default supports only the long format
--versionbut not-V.In my opinion the short form is not important to have and I suggest to stick with click´s default.I added both '-V' and '--version' in a later commit.Still to do: Adapt all other command line tools. I just added this to linkml-convert as an example to get feedback before continuing.
Closes #378