OK, so compare the code in jsonldcontextgen

linkml/linkml/generators/jsonldcontextgen.py

Lines 178 to 197 in 729f7db

    
               def add_mappings(self, defn: Definition) -> None: 
        
                   """ 
        
                   Process any mappings in defn, adding all of the mappings prefixes to the namespace map 
        
                   :param defn: Class or Slot Definition 
        
                   """ 
        
                   self.add_id_prefixes(defn) 
        
                   mappings = defn.mappings + defn.related_mappings + defn.close_mappings + \ 
        
                              defn.narrow_mappings + defn.broad_mappings + defn.exact_mappings 
        
                   for mapping in mappings: 
        
                       if '://' in mapping: 
        
                           mcurie = self.namespaces.curie_for(mapping) 
        
                           if mcurie is None: 
        
                               self.logger.warning(f"No namespace defined for URI: {mapping}") 
        
                               return        # Absolute path - no prefix/name 
        
                           else: 
        
                               mapping = mcurie 
        
                       if ':' not in mapping or len(mapping.split(':')) != 2: 
        
                           raise ValueError(f"Definition {defn.name} - unrecognized mapping: {mapping}") 
        
                       ns = mapping.split(':')[0] 
        
                       self.add_prefix(ns)

with prefixmapgen

linkml/linkml/generators/prefixmapgen.py

Lines 98 to 115 in cc956fd

    
               def add_mappings(self, defn: Definition) -> None: 
        
                   """ 
        
                   Process any mappings in defn, adding all of the mappings prefixes to the namespace map 
        
                   :param defn: Class or Slot Definition 
        
                   """ 
        
                   self.add_id_prefixes(defn) 
        
                   for mapping in defn.mappings: 
        
                       if '://' in mapping: 
        
                           mcurie = self.namespaces.curie_for(mapping) 
        
                           self.logger.warning(f"No namespace defined for URI: {mapping}") 
        
                           if mcurie is None: 
        
                               return        # Absolute path - no prefix/name 
        
                           else: 
        
                               mapping = mcurie 
        
                       if ':' not in mapping or len(mapping.split(':')) != 2: 
        
                           raise ValueError(f"Definition {defn.name} - unrecognized mapping: {mapping}") 
        
                       ns = mapping.split(':')[0] 
        
                       self.add_prefix(ns)

and pythongen

linkml/linkml/generators/pythongen.py

Lines 72 to 89 in b1e6b9d

    
               def add_mappings(self, defn: Definition) -> None: 
        
                   """ 
        
                   Process any mappings in defn, adding all of the mappings prefixes to the namespace map 
        
                   :param defn: Class or Slot Definition 
        
                   """ 
        
                   self.add_id_prefixes(defn) 
        
                   for mapping in defn.mappings: 
        
                       if '://' in mapping: 
        
                           mcurie = self.namespaces.curie_for(mapping) 
        
                           self.logger.warning(f"No namespace defined for URI: {mapping}") 
        
                           if mcurie is None: 
        
                               return        # Absolute path - no prefix/name 
        
                           else: 
        
                               mapping = mcurie 
        
                       if ':' not in mapping or len(mapping.split(':')) != 2: 
        
                           raise ValueError(f"Definition {defn.name} - unrecognized mapping: {mapping}") 
        
                       ns = mapping.split(':')[0] 
        
                       self.emit_prefixes.add(ns)

As can be seen the contextgen one is more complete as it takes into account different kinds of mappings

But why is this code duplicated? Can we not move it into a utility class or the parent Generator class?

	def add_mappings(self, defn: Definition) -> None:
	"""
	Process any mappings in defn, adding all of the mappings prefixes to the namespace map
	:param defn: Class or Slot Definition
	"""
	self.add_id_prefixes(defn)
	mappings = defn.mappings + defn.related_mappings + defn.close_mappings + \
	defn.narrow_mappings + defn.broad_mappings + defn.exact_mappings
	for mapping in mappings:
	if '://' in mapping:
	mcurie = self.namespaces.curie_for(mapping)
	if mcurie is None:
	self.logger.warning(f"No namespace defined for URI: {mapping}")
	return # Absolute path - no prefix/name
	else:
	mapping = mcurie
	if ':' not in mapping or len(mapping.split(':')) != 2:
	raise ValueError(f"Definition {defn.name} - unrecognized mapping: {mapping}")
	ns = mapping.split(':')[0]
	self.add_prefix(ns)

Need separate yaml prefix map file #192

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions