New Enabling Add-On Task#686
Merged
grampelberg merged 9 commits intolinkerd:masterfrom Jun 9, 2020
Pothulapati:trace-addon
Merged
New Enabling Add-On Task#686grampelberg merged 9 commits intolinkerd:masterfrom Pothulapati:trace-addon
grampelberg merged 9 commits intolinkerd:masterfrom
Pothulapati:trace-addon
Conversation
Signed-off-by: Tarun Pothulapati <[email protected]>
Signed-off-by: Tarun Pothulapati <[email protected]>
Signed-off-by: Tarun Pothulapati <[email protected]>
Signed-off-by: Tarun Pothulapati <[email protected]>
Signed-off-by: Tarun Pothulapati <[email protected]>
Contributor
|
@cpretzer mind giving this a runthrough? |
Contributor
|
Yep, I'll take a look |
Contributor
|
@cpretzer did you get a chance to run through this yet? |
Contributor
|
Not yet. I'll add it to my queue for today |
Signed-off-by: Tarun Pothulapati <[email protected]>
cpretzer
approved these changes
Mar 17, 2020
Contributor
cpretzer
left a comment
cpretzer
left a comment
There was a problem hiding this comment.
If we can link to a description or list of Add-On's, that would be helpful.
I ran tests using linkerd install and helm and everything worked as advertised.
More great work from @Pothulapati ⭐️
Signed-off-by: Tarun Pothulapati <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a new task which shows users on how to enable the tracing add-on.
Signed-off-by: Tarun Pothulapati [email protected]