Conversation
siggy
commented
Apr 29, 2019
|
|
||
| Note that `secret/linkerd-identity-issuer` contains the trust root of Linkerd's | ||
| Identity system, in the form of a private key. Care should be taken if storing | ||
| this information on disk, such as encrypting it in-place. |
Member
Author
There was a problem hiding this comment.
@grampelberg if you have opinions or example commands for this part, i'd be happy to incorporate, or, we can just merge and add more later.
Contributor
There was a problem hiding this comment.
Maybe recommend https://git-secret.io/ for now? I don't have any specific commands to run off the top of my head. It is fine to merge this now with the warning.
Fixes #275 Signed-off-by: Andrew Seigner <[email protected]>
siggy
force-pushed
the
siggy/from-manifests
branch
from
d8f48c2 to
09a3da8
Compare
grampelberg
approved these changes
Apr 29, 2019
Contributor
grampelberg
left a comment
grampelberg
left a comment
There was a problem hiding this comment.
Just one small style comment. It is probably worth having this become part of the docs in other places in the future, this is 100% sufficient for now.
| cat linkerd-manifests.yaml | linkerd upgrade --from-manifests - | ||
| ``` | ||
|
|
||
| Note that `secret/linkerd-identity-issuer` contains the trust root of Linkerd's |
Contributor
There was a problem hiding this comment.
Mind using {{< note >}} here?
Signed-off-by: Andrew Seigner <[email protected]>
afirth
pushed a commit
to afirth/website
that referenced
this pull request
Sep 2, 2020
Update documentation to reflect current state of kubectl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #275
Signed-off-by: Andrew Seigner [email protected]