Conversation
In order to support provisioning of short-lived identity certificates at runtime, the `io.linkerd.proxy.identity.Identity` gRPC service provides an API that proxies may use to submit Certificate Signing Requests to a new linkerd-identity controller.
olix0r
commented
Feb 13, 2019
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Feb 14, 2019
Up until now, the proxy-api controller service has been the sole service that the proxy communicates with, implementing the majoriry of the API defined in the `linkerd2-proxy-api` repo. But this is about to change: linkerd/linkerd2-proxy-api#25 introduces a new Identity service; and this service must be served outside of the existing proxy-api service in the linkerd-controller deployment (so that it may run under a distinct service account). With this change, the "proxy-api" name becomes less descriptive. It's no longer "the service that serves the API for the proxy," it's "the service that serves the Destination API to the proxy." Therefore, it seems best to bite the bullet and rename this to be the "destination" service (i.e. because it only serves the `io.linkerd.proxy.destination.Destination` service).
klingerf
pushed a commit
to linkerd/linkerd2
that referenced
this pull request
Feb 15, 2019
Up until now, the proxy-api controller service has been the sole service that the proxy communicates with, implementing the majoriry of the API defined in the `linkerd2-proxy-api` repo. But this is about to change: linkerd/linkerd2-proxy-api#25 introduces a new Identity service; and this service must be served outside of the existing proxy-api service in the linkerd-controller deployment (so that it may run under a distinct service account). With this change, the "proxy-api" name becomes less descriptive. It's no longer "the service that serves the API for the proxy," it's "the service that serves the Destination API to the proxy." Therefore, it seems best to bite the bullet and rename this to be the "destination" service (i.e. because it only serves the `io.linkerd.proxy.destination.Destination` service).
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Feb 15, 2019
Up until now, the proxy-api controller service has been the sole service that the proxy communicates with, implementing the majoriry of the API defined in the `linkerd2-proxy-api` repo. But this is about to change: linkerd/linkerd2-proxy-api#25 introduces a new Identity service; and this service must be served outside of the existing proxy-api service in the linkerd-controller deployment (so that it may run under a distinct service account). With this change, the "proxy-api" name becomes less descriptive. It's no longer "the service that serves the API for the proxy," it's "the service that serves the Destination API to the proxy." Therefore, it seems best to bite the bullet and rename this to be the "destination" service (i.e. because it only serves the `io.linkerd.proxy.destination.Destination` service). Co-authored-by: Kevin Lingerfelt <[email protected]> Signed-off-by: Kevin Lingerfelt <[email protected]>
adleong
approved these changes
Mar 11, 2019
Member
Author
|
@adleong @klingerf FYI, i brought in two more small changes into this branch:
|
olix0r
changed the title
Member
Author
|
CI failures are benign (but we need to check in Cargo.lock when we get it working again) |
klingerf
approved these changes
Mar 15, 2019
Contributor
klingerf
left a comment
klingerf
left a comment
There was a problem hiding this comment.
⭐️ Update seems good to me, but I haven't reviewed it in the context of its implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to support provisioning of short-lived identity certificates at
runtime, the
io.linkerd.proxy.identity.IdentitygRPC service providesan API that proxies may use to submit Certificate Signing Requests to a
new linkerd-identity controller.