Introduce a SkipDetect layer to preempt detection#620
Merged
Conversation
This change introduces a new SkipDetect layer that configures whether protocol detection should be attempted. This module will later be replaced/augmented by discovery. Furthermore, this change eliminates the `Accept` trait. Instead of modeling the accept stack as a simple service whose response is a future, we know model the stack as, effectively, a `MakeService<Meta, TcpStream>`. This is intended to support caching of the service that handles the tcp stream (i.e. to hold discovery responses). Detection timeouts have been moved from a dedicated layer into the detection modules.
Contributor
|
Looks like the tap test failed, but that may be flakiness? Restarting it. |
Member
Author
|
@hawkw tests pass locally... |
hawkw
suggested changes
Aug 5, 2020
Contributor
hawkw
left a comment
hawkw
left a comment
There was a problem hiding this comment.
Overall, this change seems good. However, I noticed that the way the tracing span is used in the accept loop is wrong, and will lead to messed up traces; we should fix that.
Beyond that, I had a few other minor nits and questions, but no other real blockers.
kleimkuhler
approved these changes
Aug 5, 2020
Contributor
kleimkuhler
left a comment
kleimkuhler
left a comment
There was a problem hiding this comment.
Looks good! I have a non-blocking comment.
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Aug 5, 2020
This release enables a multi-threaded runtime. Previously, the proxy would only ever use a single thread for data plane processing; now, when the proxy is allocated more than 1 CPU share, the proxy allocates a thread per available CPU. This has shown substantial latency improvements in benchmarks, especially when the proxy is serving requests for many concurrent connections. --- * Add a `multicore` feature flag (linkerd/linkerd2-proxy#611) * Add `multicore` to default features (linkerd/linkerd2-proxy#612) * admin: add an endpoint to dump spawned Tokio tasks (linkerd/linkerd2-proxy#595) * trace: roll `tracing` and `tracing-subscriber` dependencies (linkerd/linkerd2-proxy#615) * stack: Add NewService::into_make_service (linkerd/linkerd2-proxy#618) * trace: tweak tracing & test support for the multithreaded runtime (linkerd/linkerd2-proxy#616) * Make FailFast cloneable (linkerd/linkerd2-proxy#617) * Move HTTP detection & server into linkerd2_proxy_http (linkerd/linkerd2-proxy#619) * Mark tap integration tests as flakey (linkerd/linkerd2-proxy#621) * Introduce a SkipDetect layer to preempt detection (linkerd/linkerd2-proxy#620)
adleong
pushed a commit
to linkerd/linkerd2
that referenced
this pull request
Aug 6, 2020
This release enables a multi-threaded runtime. Previously, the proxy would only ever use a single thread for data plane processing; now, when the proxy is allocated more than 1 CPU share, the proxy allocates a thread per available CPU. This has shown substantial latency improvements in benchmarks, especially when the proxy is serving requests for many concurrent connections. --- * Add a `multicore` feature flag (linkerd/linkerd2-proxy#611) * Add `multicore` to default features (linkerd/linkerd2-proxy#612) * admin: add an endpoint to dump spawned Tokio tasks (linkerd/linkerd2-proxy#595) * trace: roll `tracing` and `tracing-subscriber` dependencies (linkerd/linkerd2-proxy#615) * stack: Add NewService::into_make_service (linkerd/linkerd2-proxy#618) * trace: tweak tracing & test support for the multithreaded runtime (linkerd/linkerd2-proxy#616) * Make FailFast cloneable (linkerd/linkerd2-proxy#617) * Move HTTP detection & server into linkerd2_proxy_http (linkerd/linkerd2-proxy#619) * Mark tap integration tests as flakey (linkerd/linkerd2-proxy#621) * Introduce a SkipDetect layer to preempt detection (linkerd/linkerd2-proxy#620)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces a new SkipDetect layer that configures whether
protocol detection should be attempted. This module will later be
replaced/augmented by discovery.
Furthermore, this change eliminates the
Accepttrait. Instead ofmodeling the accept stack as a simple service whose response is a
future, we now model the stack as, effectively, a
MakeService<Meta, TcpStream>. This is intended to support caching ofthe service that handles the tcp stream (i.e. to hold discovery
responses).
This change also removes the
Detecttrait. It's no longer useful.Detection timeouts have been moved from a dedicated layer into the
detection modules.